543556 - NSPR tests fail on Android due to hardcoded "/tmp" paths

Status: NEW

(NSPR :: NSPR, defect)

Description

[Ben Combee (:bcombee)]

Android devices do not have a "/tmp" folder.  Some of the NSPR tests assume that tmp exists and is writable.

For a RAM-based filesystem, you can create a /dev/tmp folder and put files there.  You also can just create a folder under /data and put files there or use the current directory like many tests do.

The failing tests because of no /tmp are:

append.c
foreign.c
sema.c
semaerr1.c
semaerr.c
semaping.c/semapong.c
socket.c
testfile.c

Comment 1

[Ben Combee (:bcombee)]

Need this patch applied before you can even build these tests

Comment 2

[Ben Combee (:bcombee)]

even with /tmp location fixed, I'm finding semaphore tests failing on Android.  The other tests I listed pass when they use files in the current directory rather than in /tmp.

Comment 3

[Wan-Teh Chang]

Ben: you can ignore the semaphore tests if your goal is to
port Mozilla/Firefox.  Mozilla/Firefox does not use NSPR
interprocess semaphores.

Comment 4

[Ben Combee (:bcombee)]

Thanks, wtc!  That's a bit less debugging/patching that I'll have to do.

Comment 5

[Ben Combee (:bcombee)]

Attachment: Fix for /tmp use in socket test

socket test also failed because of missing /tmp, this fixes it

Comment 6

[Ben Combee (:bcombee)]

Attachment: This is the first set of changes not including socket

Comment 7

[Alex Pakhotin (:alexp)]

Comment on attachment 426049 [details] [diff] [review]
This is the first set of changes not including socket

Wan-Teh, do you have any comments on these Ben's patches?

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 426048 [details] [diff] [review]
Fix for /tmp use in socket test

Please use #elif defined(ANDROID) for consistency.

Comment 9

[(not currently active) Ted Mielczarek]

Comment on attachment 426049 [details] [diff] [review]
This is the first set of changes not including socket

I think you should consistently use /data as the temp dir instead of using relative pathnames.

Comment 10

[Wan-Teh Chang]

Comment on attachment 426048 [details] [diff] [review]
Fix for /tmp use in socket test

r=wtc.  Please make the following change before you check this in.

>+#elif ANDROID

The NSPR style is to test if the macro is defined:

+#elif defined(ANDROID)

Comment 11

[BugBot [:suhaib / :marco]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.