54378 - Add Languages dialog not wide enough

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[bobj]

The Add Languages dialog (popped up by the Add button in 
Edit|Preferences|Lanaguages panel), is not resizable and does not have
horizontal scrolling, so one entry is truncated by 3 characters on my system.
    Macedonia/F.Y.R of Macedonia [mk-mk]

(momoi determined that this long name is needed to be politically correct.)

I assume the easiest "fix" is to make the dialog wider.

Comment 1

[nhottanscp]

Reassign to ftang, cc to tao.

Comment 2

[Frank Tang]

tao- do you know how to make it resizeable ?
Please help shanjian
shanjian- please help. Mark this as future.

Comment 3

[tao]

I have no answer at hand. But, you can look at Prefs dialog's implementation.
The Prefs dlg is resizable.

Comment 4

[Shanjian Li]

I do not understand why it is unsizable. I will spend some 
time to figure this out when I have time.

Comment 5

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 6

[Shanjian Li]

Attachment: proposed patch

Comment 7

[Shanjian Li]

tao, can you take a look and give a code review? Thanks.

Comment 8

[tao]

please test it on win32 and unix. juraj was having problem with UI event
clashing in adding language tab to the prefs dlg. If no problem found, r=tao.

Comment 9

[Yuying Long]

01-08-2001 Mtrunk build:
Seems the dialog works OK, it does has horizontal scroll bar with all WinME, Mac 
and Linux here, even only Linux can resize the languages panel though, but they 
you can choose and add any languages in the list.

Comment 10

[Shanjian Li]

Yuying, I just rebuild trunk build but could not see horizontal scroll bar on NT4.0. 
Are you sure it is HORIZONTAL scrollbar? There is only VERTICAL scrollbar.

Comment 11

[Yuying Long]

Sorry, it does has VERTICAL but HORIZONTAL scrollbar!

Comment 12

[Shanjian Li]

fix checked in.

Comment 13

[Yuying Long]

Checked with 01-24 Mtrunk build.  It still doesn't has HORIZONTAL scroll bar, 
but every other thing such as add the language works fine.  I don't really know 
if it is necessary to has HORIZONTAL scroll bar, if not, I'll change the bug 
status.

Comment 14

[Yuying Long]

I'll mark it as verified cause seems it works fine even it only has VERTICAL but 
HORIZONTAL scrollbar.