543854 - can't create profile with Unicode letters in name

Status: RESOLVED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[Ivan Ičin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; sr; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; sr; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)

If you enter the name of the profile with Unicode characters, Firefox displays error that he can't create profile.

It is pretty trobulesome, as localization profiles default name should be in local language, and it might require Unicode.

Reproducible: Always

Comment 1

[Simon Montagu :smontagu]

Can you test this on a nightly build? It may well be fixed by bug 469856

Comment 2

[Ivan Ičin]

No, and the error message is this:
Profile couldn't be created. Probably the chosen folder isn't writable.
[Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIToolkitProfileService.createProfile]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://mozapps/content/profile/createProfileWizard.js :: onFinish :: line 233"  data: no]

Comment 3

[Simon Montagu :smontagu]

Attachment: Patch

It might be better in some ways to make the profile name in nsIToolkitProfile a wide string instead of a UTF8String, but I don't think I want to open the migration can of worms...

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 425297 [details] [diff] [review]
Patch

I'm not sure I'm actually a peer of this code, but clearly I've reviewed stuff here for bsmedberg before.

This change looks fine, but do you think you could write a simple xpcshell test for it? This interface is scriptable, so it should be pretty straightforward. Just testing that nsIToolkitProfileService::createProfile() works as expected with an ASCII profile name, and then with a profile name that can't possibly be in the local charset ought to be enough.

r=me with a test :)

Comment 5

[Simon Montagu :smontagu]

Attachment: Test

Comment 6

[Simon Montagu :smontagu]

http://hg.mozilla.org/mozilla-central/rev/0fc982aa8276
http://hg.mozilla.org/mozilla-central/rev/ecfa4eede092

Comment 7

[[e-mail]]

Shame the test doesn't actually look for a Unicode-safe filesystem first ;-)

Comment 8

[Simon Montagu :smontagu]

(In reply to comment #7)
> Shame the test doesn't actually look for a Unicode-safe filesystem first ;-)

I don't understand this comment.