543858 - Weave's change-password/passphrase dialogs allow me to leave password/passphrase unchanged

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:
 1. In Weave Preferences, click "Manage Account" 
 2. Click "Change Password" (or "Change Secret Phrase")
 3. Complete the dialog, typing your existing password (or passphrase) in each dialog.

EXPECTED RESULTS:
The dialog should alert me that my new password (or passphrase) must be different from my old one.

ACTUAL RESULTS:
Weave says "Your password has been changed." (as in attachment 424874 [details]) and
ignores the fact that nothing's actually changed.

JUSTIFICATION OF EXPECTED RESULTS:
If a user chooses to open & fill out the "change password/passphrase" dialog, that presumably means they *want* to change it -- they're probably not intending to keep it the same.  And if they change their mind and *decide* to keep it the same, "Cancel" is still available for them to press.

Comment 1

[Daniel Holbert [:dholbert]]

I'm using:
Weave Sync 1.0
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20100202
Minefield/3.7a1pre
Ubuntu 9.10 (Karmic)

Comment 2

[Ed Lee :Mardak]

Attachment: v1

A separate issue is that the warning stays there even after the password/secret becomes valid.

Comment 3

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/88391959b484
Check if the new value is the same as the current one and provide a warning.