543866 - Weave's "change password" dialog closes with cryptic message "there was an error changing your password", if new password is too simple

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:
 1. In Weave Preferences, click "Manage Account" 
 2. Click "Change Password" or "Change Secret Phrase"
 3. Type in your existing password in first field, and type 'a' in the next two fields, as your new password.
 4. Press 'Enter' or click 'OK'

ACTUAL RESULTS:
A message appears on the dialog saying "There was an error changing your password.", and (after ~1s) the dialog disappears.

EXPECTED RESULTS:
Weave shouldn't close the dialog -- instead, it should alert me to what the problem was, and let me update the dialog's text fields accordingly.

NOTE: I get EXPECTED RESULTS if I leave the new-password field completely blank, or if my new passwords don't match.

I'm using:
Weave Sync 1.0
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20100202
Minefield/3.7a1pre
Ubuntu 9.10 (Karmic)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of dialog with error message

Here's a screenshot of the dialog, with the error message that briefly appears before the dialog auto-hides.

(Note that this screenshot exhibits bug 543857, too -- OK/Cancel buttons are pushed off the bottom)

Comment 2

[Mike Connor [:mconnor]]

Was fixed in ~1.3 when we made the change dialog enforce minimum length of 8.

Comment 3

[Tracy Walker [:tracy]]

verified with 20101013 build of minefield