544071 - Unresponsive script dialog "Yes" option not clear

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Marcia Knous [:marcia]]

Seen while running 20100202 build.

STR:
1. Visit a site that generates an unresponsive script dialog. In my case it was addons.mozilla.org
2. Observe the UI in the attached screenshot

Comment 1

[Marcia Knous [:marcia]]

Attachment: Screenshot of dialog

Comment 2

[Marcia Knous [:marcia]]

Aakash showed me that by pressing the key that the yes shows, but in some way the UI seems funny in this respect so leaving this bug open for the UI issue.

Comment 3

[Mike Kristoffersen (:MikeK)]

Maybe it's because I'm not a native English speaker, but even it was more clear for the user to choose between the yes and no option, I don't think the wording in the dialog is very nice.  Don't ask me again: "Yes" - what does that mean?  

I am confused if I should select, Don't ask me again - "No" <, don't ask me again>, or Don't ask me again - "Yes" <I select not to be asked again> - I could be simplified by removing a negation(?) and change the text to something like: "Ask me again?" where the user has to choose the answer (yes/no). Or even better if possible, let the user choose between "Ask me again" and "Don't ask me again"

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

This isn't winmo only as this dialog is common across all platforms. I also agree that the wording is very confusing. Madhava, your thoughts please?

Comment 5

[Madhava Enros [:madhava]]

This is definitely an awkward wording, and comes from our changing from a wordless checkbox to standard [yes/no] toggles. More than awkward, actually -- really confusing.

To make it work with a [yes/no], one better phrasing would be:

Ask every time [yes/no]  **note that this involves reversing the yes/no meanings.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

If anyone has ideas on how we could invert the meaning of the boolean passed to the promptservice, let me know.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

I pitched a different idea to Brad. What if we used a button for the question instead of a label and a yes/no toggle?

Instead of:

"Don't ask me again" [yes|no]

Think of:

( [x] Don't ask me again )

The label and a check/uncheck image would be on a button. The user could press the full button to toggle.

Comment 8

[Mike Kristoffersen (:MikeK)]

(In reply to comment #7)
<SNIP>
> Think of:
> 
> ( [x] Don't ask me again )
> 
> The label and a check/uncheck image would be on a button. The user could press
> the full button to toggle.

Do you mean that the text on the button change between:

( [x] Don't ask me again )

and:

( [ ] Don't ask me again )

?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #8)

> Do you mean that the text on the button change between:
> 
> ( [x] Don't ask me again )
> 
> and:
> 
> ( [ ] Don't ask me again )

Exactly

Comment 10

[Mike Kristoffersen (:MikeK)]

(In reply to comment #9)
> (In reply to comment #8)
> 
> > Do you mean that the text on the button change between:
> > 
> > ( [x] Don't ask me again )
> > 
> > and:
> > 
> > ( [ ] Don't ask me again )
> 
> Exactly

Definitively better than what we have now.  (And similar to what users see on PC's - so as long as it fits with the way we do it in other places in Fennec (Madhava your comments?), then it's probably the best solution.)

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: WIP

This patch tweaks the confirm dialog to use a button-checkbox instead of a label and [yes/no] toggle.

We need a real checked/unchecked image and some styling.

screenshot:
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-prompt-buttoncheck-01.png
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-prompt-buttoncheck-02.png

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch:
* adds check and uncheck images
* removes any button styling
* removes the focus rectangle (it is still in the screenshots though)

Examples:
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-confirm-buttoncheck.png
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-confirm-buttoncheck-unselected.png
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-confirm-buttoncheck-portrait-unselected.png

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-b:
http://hg.mozilla.org/mobile-browser/rev/ccc372e078aa

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-1.1:
http://hg.mozilla.org/releases/mobile-1.1/rev/ce8e264e7583

Comment 15

[Aakash Desai [:aakashd]]

Is there a way to create a testpage which will bring up the unresponsive script dialog in a always reproducible way?

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #15)
> Is there a way to create a testpage which will bring up the unresponsive script
> dialog in a always reproducible way?

I don't know of any, but you can get the same type of dialog to appear by having more than 1 tab open in Fennec and then close the app. You should get the "Close tabs" dialog, with a checkbox widget.

Comment 17

[Martijn Wargers (dead)]

Attachment: testcase

This triggers the unresponsive script dialog for me on fennec.
It seems to completely hang current trunk builds of Firefox, though (I thought the unresponsive script dialog should appear there, too?).

Comment 18

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100506 Namoroka/3.6.5pre Fennec/1.1b2pre

and

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100506 Namoroka/3.7a5pre Fennec/2.0a1pre