Closed
Bug 544137
Opened 15 years ago
Closed 15 years ago
Create redirect for "plugin-crashed" help-topic
Categories
(support.mozilla.org :: General, defect)
support.mozilla.org
General
Tracking
(Not tracked)
VERIFIED
FIXED
1.5.1
People
(Reporter: cilias, Assigned: laura)
References
Details
Attachments
(1 file, 1 obsolete file)
2.29 KB,
patch
|
jsocol
:
review+
|
Details | Diff | Splinter Review |
We need the help-topic "plugin-crashed" to redirect to the article:
Plugin+crash+reports?style_mode=inproduct
For further info see bugs 538910 and 542410.
For QA:
Right now, we've got a placeholder that redirects to the "Firefox crashes" article, so that's were you should end up for now.
Reporter | ||
Updated•15 years ago
|
Target Milestone: --- → 1.5.2
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → laura
Comment 1•15 years ago
|
||
Don't forget to add an &as=u parameter to the query string to the rewrite to keep track of article hits coming from the UI.
Comment 2•15 years ago
|
||
Any chance we could get this done today? I'm planning on landing the patches that implement this today, so the link will be in tomorrow's trunk nightly.
Reporter | ||
Comment 3•15 years ago
|
||
Don't let this hold you back. We're still waiting for QA to sign off on SUMO 1.5.1 before we can schedule a push to production. And this is a SUMO 1.5.2 bug (filed after 1.5.1 froze).
Updated•15 years ago
|
Blocks: LorentzAlpha
Comment 4•15 years ago
|
||
The browser UI has landed and is live, and of course now we're getting reports that it's "broken" because this redirect is missing.
This shouldn't block on Sumo 1.5.2, the comment in bug 542410 indicates that this is a trivial 1-line htaccess change. Soon we'll be shipping a Firefox alpha with this link is a high-visibility UI which makes it even more important to get this working.
Comment 5•15 years ago
|
||
Laura, can we do a separate push to get this out asap?
Assignee | ||
Comment 6•15 years ago
|
||
Aiming to push 1.5.1 Thursday, I'll get it in ASAP.
Target Milestone: 1.5.2 → 1.5.1
Comment 7•15 years ago
|
||
Thanks Laura!
Assignee | ||
Comment 8•15 years ago
|
||
Attachment #427189 -
Flags: review?(james)
Assignee | ||
Comment 9•15 years ago
|
||
Oho, I forgot the EU ballot changes. revised patch on the way.
Assignee | ||
Comment 10•15 years ago
|
||
Attachment #427189 -
Attachment is obsolete: true
Attachment #427194 -
Flags: review?(james)
Attachment #427189 -
Flags: review?(james)
Comment 11•15 years ago
|
||
Comment on attachment 427194 [details] [diff] [review]
with eu stuff this time
The patch failed 2/2 on a clean checkout of the 1.5.1_temp branch. Does it depend on having the Weave patch applied first? If so, feel free to re-request after that's landed.
Attachment #427194 -
Flags: review?(james) → review-
Comment 12•15 years ago
|
||
After applying all the patches that had already been applied to trunk, this still failed 1/2, the second hunk.
Assignee | ||
Comment 13•15 years ago
|
||
It depends on the Weave patch and the as=u patch and was diffed against updated trunk. I'll see if I can work out what the problem is, it's a two line patch so it can't be that hard.
Assignee | ||
Comment 14•15 years ago
|
||
jsocol: applying this patch still wfm on trunk and branch, clean checkout of r62529. Can you try again?
Comment 15•15 years ago
|
||
Comment on attachment 427194 [details] [diff] [review]
with eu stuff this time
After all the other commits, patch finally applied.
And it works for me.
Attachment #427194 -
Flags: review- → review+
Assignee | ||
Comment 16•15 years ago
|
||
In r62534/r62535
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Flags: in-testsuite?
Flags: in-litmus?
Reporter | ||
Comment 18•15 years ago
|
||
Justin, 1.5.1 has pushed. The link from trunk builds should point people to the "Firefox crashes" article.
Updated•14 years ago
|
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•