544146 - [Caret browsing]Hitting SPACE causes to set-focus/fire-submit to last element that can have focus

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[Masahiro YAMADA]

Attachment: testcase

Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2) Gecko/20100115 Firefox/3.6
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20100202 Minefield/3.7a1pre

At caret browsing mode, when page loading finished, last element that can have focus already have focus without focus ring.
If focuesd element is submit button , hitting [SPACE] key causes form submit, not page scrolling.

Steps to reproduce:

 1.Start Caret browsing mode
 2.show testcase in same tab.
 3.hit space

  Order of steps is very important.
  When entering caret browsing after page load, problem is not reproduced.

Expected result:
  All links should not get focus.
Acutual result:
  Link at bottom gets focus (background-color will be red)

Comment 1

[Masahiro YAMADA]

Attachment: testcase2

When last element is submit button , hitting SPACE causes to submit form.

Comment 2

[Masahiro YAMADA]

I found this problem at Japanese user's forum.
According to original report, this problem is not reproduced at Fx3.5.7

Comment 3

[Hideo Oshima]

I can reproduce with recent trunk/Linux.

Comment 4

[Masahiro YAMADA]

Not reproduced:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090610 Minefield/3.6a1pre
http://hg.mozilla.org/mozilla-central/rev/90d3e6d2cbb9

Reproduced:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090611 Minefield/3.6a1pre 
http://hg.mozilla.org/mozilla-central/rev/4430cae50dad

Comment 5

[Masahiro YAMADA]

reression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2009-06-09+21%3A00%3A00&enddate=2009-06-11+03%3A00%3A00

It may be regression of bug 178324

Comment 6

[Neil Deakin]

Attachment: fix

This patch:
 - changes the direction to always be forward for focusing-to-caret mode
 - when the caret is not set at any location, or is at the root, don't call
GetFocusInSelection but return early so that we don't continue looking for a
node to focus.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

This needs to be fixed on branch; accidental form submissions are pretty bad.

Comment 8

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/f353b4ec86ff

Comment 9

[Masahiro YAMADA]

-->VERIFIED

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a2pre) Gecko/20100224 Minefield/3.7a2pre

Comment 11

[Masahiro YAMADA]

Can we land patch to Branch ?

Comment 12

[Daniel Veditz [:dveditz]]

This was marked blocking1.9.2:needed in February but nothing much happened. Seems like it ought to be blocking, renom-ing to see if that's still the right state or if maybe there's some missing prerequisite for a branch landing.

Comment 13

[Daniel Veditz [:dveditz]]

Comment on attachment 425494 [details] [diff] [review]
fix

Approved for 1.9.2.6, a=dveditz for release-drivers

Comment 14

[Neil Deakin]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/34c868ca9c88