Closed Bug 544168 Opened 12 years ago Closed 12 years ago

nsIEditorIMESupport::endComposition shouldn't be scriptable

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/editor/idl/nsIEditorIMESupport.idl

endComposition() must not be scriptable. That is used for the editor event listeners notify the composition event event to the editor.

If the developers want to commit the composition, they should use forceCompositionEnd().
Summary: nsIEditor::endComposition shouldn't be scriptable → nsIEditorIMESupport::endComposition shouldn't be scriptable
Attached patch Patch v1.0Splinter Review
I guess that we can move the scriptable methods and properties to nsIEditor, then, we can remove the interface... but this is ok for now.
Attachment #425426 - Flags: superreview?(Olli.Pettay)
Attachment #425426 - Flags: review?(Olli.Pettay)
Attachment #425426 - Flags: superreview?(Olli.Pettay)
Attachment #425426 - Flags: superreview+
Attachment #425426 - Flags: review?(Olli.Pettay)
Attachment #425426 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/e544343970b4
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
You need to log in before you can comment on or make changes to this bug.