QCore version needed to replace message_pump_glib.cc

RESOLVED FIXED in mozilla1.9.3a2

Status

()

Core
IPC
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla1.9.3a2
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 5 obsolete attachments)

(Assignee)

Description

9 years ago
Currently QtPort is not compiling  message_pump_glib.cc, we need to write Qt version for this functionality
(Assignee)

Comment 1

9 years ago
Created attachment 426289 [details] [diff] [review]
Qt version for message pump
Assignee: nobody → romaxa
Attachment #426289 - Flags: review?(jones.chris.g)
(Assignee)

Updated

9 years ago
Attachment #426289 - Flags: review?(jones.chris.g) → review?(mozbugz)

Comment 2

9 years ago
Comment on attachment 426289 [details] [diff] [review]
Qt version for message pump

lets get ted to look at the build change... I think it is fine, but I haven't added or thought about adding any MOC commands.  Maybe he is aware of issues that I am not.

Not sure if we add contributor lines to chrome licensed files?
+// Contributor Oleg Romashin <romaxa@gmail.com>


Not sure about this comment:
+  // Make sure we only run this on one thread.  GTK only has one message pump

Maybe you should make ProcessNextNativeEvent because you are not using the return result of dispatcher->processEvents.


In your header, please comment as to what a MessagePumpQt qt_pump; is.


I do not think that ProcessNextNativeEvent, or &pump have to be public, do they?

look good so far!
Attachment #426289 - Flags: review?(mozbugz) → review-

Comment 3

9 years ago
Comment on attachment 426289 [details] [diff] [review]
Qt version for message pump

ted, can you provide feedback on the config rules
Attachment #426289 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 4

9 years ago
Created attachment 426325 [details] [diff] [review]
dougt comments updated.
Attachment #426325 - Flags: review?(mozbugz)

Updated

9 years ago
Attachment #426325 - Flags: review?(ted.mielczarek)
Attachment #426325 - Flags: review?(mozbugz)
Attachment #426325 - Flags: review+

Updated

9 years ago
Attachment #426289 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 5

9 years ago
Created attachment 426349 [details] [diff] [review]
More fixes, and removed ProcessNextNative event function
Attachment #426289 - Attachment is obsolete: true
Attachment #426349 - Flags: review?(mozbugz)

Comment 6

9 years ago
Comment on attachment 426349 [details] [diff] [review]
More fixes, and removed ProcessNextNative event function

innerdiff fail.  comments below:


>+moc_%.cc: %.cc $(GLOBAL_DEPS)
>+	$(REPORT_BUILD)
>+	$(ELOG) $(MOC) $(shell echo $(_VPATH_SRCS) | sed "s/.cc//").h $(OUTOPTION)$@
>+

Ted needs to review this part.

>+namespace {
>+
>+static int sPokeEvent;

Go ahead and add a comment above this.


grep for glib in these files.  i do not think that any apply
Attachment #426349 - Flags: review?(mozbugz) → review-
(Assignee)

Comment 7

9 years ago
Created attachment 426387 [details] [diff] [review]
Removed not used functions and fixed glib description, added some comments
Attachment #426349 - Attachment is obsolete: true
Attachment #426387 - Flags: review?(mozbugz)
(Assignee)

Comment 8

9 years ago
Created attachment 426486 [details] [diff] [review]
Better version for rules.mk implementation, NeilAway advice.
Attachment #426325 - Attachment is obsolete: true
Attachment #426387 - Attachment is obsolete: true
Attachment #426486 - Flags: review?(mozbugz)
Attachment #426387 - Flags: review?(mozbugz)
Attachment #426325 - Flags: review?(ted.mielczarek)

Comment 9

9 years ago
what happened to the 

#if (QT_VERSION >= QT_VERSION_CHECK(4, 4, 0))

check?
(Assignee)

Comment 10

9 years ago
Created attachment 426520 [details] [diff] [review]
Fix debian stable compilation

Yep, debian stable still using Qt 4.4.3.... we need that check.
Attachment #426486 - Attachment is obsolete: true
Attachment #426520 - Flags: review?(mozbugz)
Attachment #426486 - Flags: review?(mozbugz)

Updated

9 years ago
Attachment #426520 - Flags: review?(mozbugz) → review+
(Assignee)

Comment 11

9 years ago
pushed in
http://hg.mozilla.org/projects/electrolysis/rev/eb57ae66e03f
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Comment 12

9 years ago
Ups wrong bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
please bump the copyright to 2010.
(Assignee)

Comment 14

9 years ago
Created attachment 427609 [details] [diff] [review]
Copyright fix
(Assignee)

Comment 15

9 years ago
Pushed in:
http://hg.mozilla.org/mozilla-central/rev/70ef55e0f2f5
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
Assuming "checkin-needed" keyword no longer applies.

Also, this caused minor bustage:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1266530142.1266533266.28256.gz

> TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
> TEST-INFO | check-sync-dirs.py | file(s) found in:               /builds/moz2_slave/mozilla-central-macosx/build/js/src/config
> TEST-INFO | check-sync-dirs.py | differ from their originals in: /builds/moz2_slave/mozilla-central-macosx/build/config
> TEST-INFO | check-sync-dirs.py | differing file:                 ./rules.mk
> In general, the files in '/builds/moz2_slave/mozilla-central-
> macosx/build/js/src/config' should always be exact copies of originals in
> '/builds/moz2_slave/mozilla-central-macosx/build/config'.  A change made to
> one should also be made to the other.  See 'check-sync-dirs.py' for more
> details.
> make[1]: *** [check] Error 1
> make: *** [check] Error 2
> program finished with exit code 2

This bug's changes to the file "config/rules.mk" need to be mirrored in js/src/config.
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a2
You need to log in before you can comment on or make changes to this bug.