544190 - QCore version needed to replace message_pump_glib.cc

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Oleg Romashin (:romaxa)]

Currently QtPort is not compiling  message_pump_glib.cc, we need to write Qt version for this functionality

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Qt version for message pump

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 426289 [details] [diff] [review]
Qt version for message pump

lets get ted to look at the build change... I think it is fine, but I haven't added or thought about adding any MOC commands.  Maybe he is aware of issues that I am not.

Not sure if we add contributor lines to chrome licensed files?
+// Contributor Oleg Romashin <[e-mail]>


Not sure about this comment:
+  // Make sure we only run this on one thread.  GTK only has one message pump

Maybe you should make ProcessNextNativeEvent because you are not using the return result of dispatcher->processEvents.


In your header, please comment as to what a MessagePumpQt qt_pump; is.


I do not think that ProcessNextNativeEvent, or &pump have to be public, do they?

look good so far!

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 426289 [details] [diff] [review]
Qt version for message pump

ted, can you provide feedback on the config rules

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: dougt comments updated.

Comment 5

[Oleg Romashin (:romaxa)]

Attachment: More fixes, and removed ProcessNextNative event function

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 426349 [details] [diff] [review]
More fixes, and removed ProcessNextNative event function

innerdiff fail.  comments below:


>+moc_%.cc: %.cc $(GLOBAL_DEPS)
>+	$(REPORT_BUILD)
>+	$(ELOG) $(MOC) $(shell echo $(_VPATH_SRCS) | sed "s/.cc//").h $(OUTOPTION)$@
>+

Ted needs to review this part.

>+namespace {
>+
>+static int sPokeEvent;

Go ahead and add a comment above this.


grep for glib in these files.  i do not think that any apply

Comment 7

[Oleg Romashin (:romaxa)]

Attachment: Removed not used functions and fixed glib description, added some comments

Comment 8

[Oleg Romashin (:romaxa)]

Attachment: Better version for rules.mk implementation, NeilAway advice.

Comment 9

[Doug Turner (:dougt)]

what happened to the 

#if (QT_VERSION >= QT_VERSION_CHECK(4, 4, 0))

check?

Comment 10

[Oleg Romashin (:romaxa)]

Attachment: Fix debian stable compilation

Yep, debian stable still using Qt 4.4.3.... we need that check.

Comment 11

[Oleg Romashin (:romaxa)]

pushed in
http://hg.mozilla.org/projects/electrolysis/rev/eb57ae66e03f

Comment 12

[Oleg Romashin (:romaxa)]

Ups wrong bug.

Comment 13

[Doug Turner (:dougt)]

please bump the copyright to 2010.

Comment 14

[Oleg Romashin (:romaxa)]

Attachment: Copyright fix

Comment 15

[Oleg Romashin (:romaxa)]

Pushed in:
http://hg.mozilla.org/mozilla-central/rev/70ef55e0f2f5

Comment 16

[Daniel Holbert [:dholbert]]

Assuming "checkin-needed" keyword no longer applies.

Also, this caused minor bustage:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1266530142.1266533266.28256.gz

> TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
> TEST-INFO | check-sync-dirs.py | file(s) found in:               /builds/moz2_slave/mozilla-central-macosx/build/js/src/config
> TEST-INFO | check-sync-dirs.py | differ from their originals in: /builds/moz2_slave/mozilla-central-macosx/build/config
> TEST-INFO | check-sync-dirs.py | differing file:                 ./rules.mk
> In general, the files in '/builds/moz2_slave/mozilla-central-
> macosx/build/js/src/config' should always be exact copies of originals in
> '/builds/moz2_slave/mozilla-central-macosx/build/config'.  A change made to
> one should also be made to the other.  See 'check-sync-dirs.py' for more
> details.
> make[1]: *** [check] Error 1
> make: *** [check] Error 2
> program finished with exit code 2

This bug's changes to the file "config/rules.mk" need to be mirrored in js/src/config.

Comment 17

[Daniel Holbert [:dholbert]]

pushed bustage fix per comment 16:
http://hg.mozilla.org/mozilla-central/rev/adea50839081