If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Qt version for plugins embedding functionality required

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Plugins embedding for linux require Qt version

Currently it is ifdef-ed for GTK only
http://mxr.mozilla.org/mozilla-central/source/dom/plugins/PluginModuleChild.cpp#181
http://mxr.mozilla.org/mozilla-central/source/dom/plugins/PluginModuleChild.cpp#261
(Assignee)

Comment 1

8 years ago
Created attachment 426304 [details] [diff] [review]
This should fix QT windowless plugins with ipc enalbed plugins.
Assignee: nobody → romaxa
Attachment #426304 - Flags: review?(mozbugz)

Updated

8 years ago
Attachment #426304 - Flags: review?(mozbugz) → review+

Comment 2

8 years ago
Comment on attachment 426304 [details] [diff] [review]
This should fix QT windowless plugins with ipc enalbed plugins.

fix the spacing here... add a space after defined +#if defined (MOZ_WIDGET_GTK2) || defined(MOZ_WIDGET_QT)
(Assignee)

Comment 3

8 years ago
Pushed in:
http://hg.mozilla.org/mozilla-central/rev/6162acadbec4
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.