Closed Bug 544390 Opened 14 years ago Closed 14 years ago

(regression) odd display of the contents of the About dialog (offset to the right)

Categories

(Firefox :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.7a3

People

(Reporter: phiw2, Assigned: Gavin)

References

Details

(Keywords: regression)

Attachments

(2 files, 2 obsolete files)

STR
1. Open About Minefield window (Minefield menu > About Minefield

A.R. Content is offset to the right (see attached screenshot), in a very narrow vertical strip
E.R  Content fills the window.

works
Gecko/20100125 Minefield/3.7a1pre
http://hg.mozilla.org/mozilla-central/rev/d8177ec0014c

fails
Gecko/20100126 Minefield/3.7a1pre
http://hg.mozilla.org/mozilla-central/rev/e436d3c5a4a6

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d8177ec0014c&tochange=e436d3c5a4a6

possibly due to bug 536336.

Playing with the DOMinspecor, I change the string for 'licensing information' to something very long. Then the whole thing displayed correctly. bug 536336 changed that whole string.
Attached image screenshot
Unofficial branding only (since my Mac official branding builds, with the bit about the Firefox logos following the "Licensing information" link are fine), and Mac or Mac and Linux only (since my Windows unofficial branding build looks fine).
Component: General → Theme
QA Contact: general → theme
(In reply to comment #2)
>  Mac or Mac and Linux only (since my Windows unofficial branding build looks
> fine).

Mac only. The nightly I have running  on a Linux VM is fine.
Though I guess since it's only themed by global/skin/, it would have to be Toolkit: Themes if it's a theme bug.
Attached patch v1 (obsolete) — Splinter Review
I think the purpose of this align="end" was to make the Credits button align right. That button is an extra2 button, and extra2 buttons are put in front of a flexing spacer in the dialog-button-box. Aligning the dialog-button-box right (instead of stretching it to the full width) had the effect of collapsing that spacer.
With this patch the Credits button will be left aligned. Is that OK?
Attachment #425773 - Flags: review?(gavin.sharp)
Blocks: 536336
Component: Theme → General
QA Contact: theme → general
Attached patch alternate patch (obsolete) — Splinter Review
I think this is better, since it maintains the button position. It's an ugly hack, but I don't think we have any better ways to get a single right-aligned button on Mac dialogs. We probably should...
Attachment #425773 - Attachment is obsolete: true
Attachment #429615 - Flags: review?(dao)
Attachment #425773 - Flags: review?(gavin.sharp)
Summary: (regression) odd display of the contents of the About window (offset to the right) → (regression) odd display of the contents of the About dialog (offset to the right)
This
This looks like it should be a 300px min-width on #clientBox.
Yep, that works.
Assignee: nobody → gavin.sharp
Attachment #429615 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #429773 - Flags: review?(dao)
Attachment #429615 - Flags: review?(dao)
Comment on attachment 429773 [details] [diff] [review]
alternate patch v2

This looks quite correct to me. Why does the comment say "XXX"? Speaking of the comment, it might be helpful to mention OS X and/or align="end" as well.
Attachment #429773 - Flags: review?(dao) → review+
How's this?

  /* Add a min-width equal to chrome://branding/content/about.png's
   * width, to maintain the dialog layout on OS X where the dialog is
   * align="end" to right-align the button.
   */
Sounds perfect.
https://hg.mozilla.org/mozilla-central/rev/2028802a7a35
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: