544396 - xpcshell-tests, test_downloadOffline.js: some code clean-up

Status: RESOLVED DUPLICATE of bug 765958

(MailNews Core :: Networking: IMAP, defect)

Description

[Serge Gautherie (:sgautherie)]

Moved from bug 504504 comment 4:
{
Serge Gautherie (:sgautherie)      2010-01-31 17:33:53 PST

(From update of attachment 423142 [details] [diff] [review])
While there,

>@@ -97,19 +97,21 @@ var UrlListener =

85     if (!gDownloadedOnce) {
86       gDownloadedOnce = true;
87       gIMAPInbox.downloadAllForOffline(UrlListener, null);
88       return;
89     }
90     else {

Could you remove this "_else_ after return"?

>       }
>-      endTest();
>     }
>     do_timeout(1000, endTest);

Not knowing this test, I wonder why this is needed.
Is it a case of the first of the two "endTest" calls to run wins?
Could that be documented?

>+  },
>+  finalize: function() {
>+    do_timeout(0, endTest);
>   }
> };
}

And maybe use executeSoon().

Comment 1

[:aceman]

It seems this got fixed as part of bug 765958.