544420 - backupsnip fails when only adding new directories

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Exit early if no directories to backup

$ ~/bin/backupsnip 20100204-Firefox-3.0.18-3.6-MU-test
Ignoring Firefox/3.0.18/Darwin_Universal-gcc3
Ignoring Firefox/3.0.18/Linux_x86-gcc3
Ignoring Firefox/3.0.18/WINNT_x86-msvc
Running time /bin/tar cfvz /opt/aus2/snippets/backup/20100204-1-pre-20100204-Firefox-3.0.18-3.6-MU-test.tar.gz
/bin/tar: Cowardly refusing to create an empty archive
Try `/bin/tar --help' or `/bin/tar --usage' for more information.

Those major update snippets only add the directories listed.

Comment 1

[Chris AtLee [:catlee]]

Comment on attachment 425377 [details] [diff] [review]
Exit early if no directories to backup

if $args has more than one entry, then '[ -z $args ]' errors out with '[: 5: file1: unexpected operator' (or somesuch)

I think $args needs to be in double quotes.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Quote list of dirs to keep bash a happy camper

"-bash: [: too many arguments" is the error. Adds the suggested quotes to resolve the problem.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 428165 [details] [diff] [review]
Quote list of dirs to keep bash a happy camper

Checking in backupsnip;
/cvsroot/mozilla/tools/release/bin/backupsnip,v  <--  backupsnip
new revision: 1.6; previous revision: 1.5
done

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Updated the checkout on aus2-staging and staging-stage (this one was at v1.3 of backupsnip and wasn't running backupsnip-nightly, fixed).