544472 - Improve calls to nsBox::AddCSS***Size

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Neil Deakin]

Attachment: changes

These methods are called twice in some cases. This patch removes this and removes some additional unneeded indirection of the other AddCSS*** calls.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 425455 [details] [diff] [review]
changes

Given that you removed GetDefaultFlex, I think you should at least make
nsIBox::AddCSSFlex have the part that gets the flex from
aBox->GetStyleXUL() be outside the if(content).  (It's easy to do if you
also put the IsEmpty check outside that if.)  And I tend to think you
should probably do the same for nsIFrame::GetOrdinal.  Though that could
be a separate patch to make regression-hunting easier if you want, on
the off chance it causes problems.  (Feel free to count the r=dbaron on
that too.)

You should also remove nsGroupBoxFrame::GetDefaultFlex (you're removing
the only caller) and nsSprocketLayout::GetDefaultFlex (unused already).



Another potential followup is changing the nsBoxLayoutState& param to
AddCSSMinSize to a nsIRenderingContext*.  (We might at some point need
that on AddCSSPrefSize too if we fix the native theme API to distinguish
min and pref better, which I believe at least Windows can do.)


r=dbaron, and again sorry for taking so long to get to this

Comment 2

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/a35c6813e87d

Comment 3

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336