544512 - Misaligned accesses in uconv causes Bus Error on sparc and word wrapping on arm

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Patch

There are 2 places where misaligned accesses can happen and lead to bus errors on sparc. The attached patch addresses both issues. I think the same applies to trunk.

With the patch and the one in bug 448658, xpcshell-tests and make check pass on a xulrunner build (i.e. the few tests that live in browser/ are not run) on sparc.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch v2

This is also a problem on ARM, because it wraps at word boundary. On a 16-bit word, that inverts endianness, and on 32-bit words, this can have very unpleasant side effects. These problems are detected by the current test suite, so they don't need new tests, but an additional fix is obviously necessary.

Also note there could be problems when reading the BOM a few lines above, but as this is supposed to happen only at the beginning of the buffer, and I expect the buffer to be sufficiently aligned, it shouldn't be a problem. Or are there places feeding an unaligned buffer to convert ?

Comment 2

[Simon Montagu :smontagu]

(In reply to comment #1)
> Also note there could be problems when reading the BOM a few lines above, but
> as this is supposed to happen only at the beginning of the buffer, and I expect
> the buffer to be sufficiently aligned, it shouldn't be a problem. Or are there
> places feeding an unaligned buffer to convert ?

Not as far as I know.

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/08355dd0c188