544585 - reduce or remove virtual functions from the result nodes

Status: RESOLVED INVALID

(Toolkit :: Places, defect)

Description

[Dietrich Ayala (:dietrich)]

see brendan's comment here:

https://bugzilla.mozilla.org/show_bug.cgi?id=513149#c23

these will be called frequently in most places views:

http://mxr.mozilla.org/mozilla-central/search?find=%2Ftoolkit%2Fcomponents%2Fplaces%2Fsrc%2F&string=virtual

Comment 1

[Marco Bonardo [:mak]]

the current uses look correct to me, while virtual methods are usually bad for performance reasons, their need has to be evaluated on a per-case basis, fwiw we mostly have virtual destructors and some methods that we need, they are not overused, the only effective way to remove them would be to rewrite that code in js.