Closed
Bug 544656
Opened 16 years ago
Closed 16 years ago
fixing "keepAtoms can be used uninitialized" warning for js_GC()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
2.54 KB,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
The changes for the bug 541790 has triggered a warning with GCC:
/home/igor/m/tm/js/src/jsgc.cpp:2873: warning: ‘keepAtoms’ may be used uninitialized in this function
It should be fixed to minimize warning noise.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #425638 -
Flags: review?(brendan)
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 425638 [details] [diff] [review]
fix
>+ bool keepAtoms = (gckind & GC_KEEP_ATOMS) || (rt->gcKeepAtoms != 0);
No need to parenthesize the != 0 expression. r=me with that picked.
/be
Attachment #425638 -
Flags: review?(brendan) → review+
|
|
Assignee | |
Updated•16 years ago
|
blocking2.0: alpha1 → ?
|
|
Assignee | |
Comment 3•16 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Updated•16 years ago
|
blocking2.0: ? → alpha2
|
||
Comment 4•16 years ago
|
||
This got merged to m-c at some point, marking it FIXED to get it off the alpha2 radar.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•