544682 - months should be viewed with different color to avoid confusion

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, enhancement)

Description

[Nicolas Tsiros]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; es-AR; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)
Build Identifier: Lightning/1.0b1

pair months should be viewed in a colour, and odd months should be viewed in another colour to make easier avoid confusion

Reproducible: Always

Steps to Reproduce:
going to calendar at lightning

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

We won't be making this part of the core product, but I will add some attributes to our views that allow doing this via userChrome.css

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This patch cleans up some style and adds a couple of attributes.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: userChrome.css

This is an example userchrome.css which can be used to customize the view. If you would like to use it, please go to your Profile (see https://support.mozillamessaging.com/en-US/kb/Profiles), create a directory "chrome", then save this attachment there with the name userChrome.css.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

I'm folding bug 545135 into this one, since the patch is small and has a similar topic.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: userChrome.css

Updated userChrome.css showing usage of both attributes.

Comment 7

[Markus Adrario [:Taraman]]

Comment on attachment 431141 [details] [diff] [review]
Fix - v2

patch looks good to me.

compiles and works as expected.

Only thing that nags me is that we change the color of the whole Item-box for the Privacy-display.
This is OK, if I have just a few items with privacy set.
I example have an imported calendar with holidays, which are all set public. On that calendar, the patch in fact changes the color preset of the whole calendar.

I could live with that, since it's a user-preference and not enabled by default, but I think we should look for a better solution here.

So for the technical part the patch is
    r=markus
but I'd love to see an ui-review here.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

The userChrome.css attached is only an example. Its up to each user to make the changes he or she wants, i.e the user could instead add a background-image for public events. Therefore I don't think this needs any ui-review, which is rather reserved for changes made to the default theme and checked in.

Thanks for looking into this.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/40e28a249b3d>

-> FIXED