[TSF] Remove WM_USER_TSF_TEXTCHANGE

RESOLVED FIXED in mozilla29

Status

()

Core
Widget: Win32
RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod})

Trunk
mozilla29
x86
Windows 7
inputmethod
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

The WM_USER_TSF_TEXTCHANGE hack should be removed. Instead of that, nsIMEStateManager should notify the content/selection changes after the change completed.
Keywords: inputmethod
Created attachment 461990 [details] [diff] [review]
Add script runners for selection/text notification

Masayuki-san, can you comment on this? This patch adds script runners for widget notifications.

Fixing this bug would be very helpful for Android.
Attachment #461990 - Flags: feedback?(masayuki)
Comment on attachment 461990 [details] [diff] [review]
Add script runners for selection/text notification

looks great, thank you.

# Bug don't close this bug only with this patch, I'll post a patch of TSF after your patch will be landed.
Attachment #461990 - Flags: feedback?(masayuki) → feedback+
Comment on attachment 461990 [details] [diff] [review]
Add script runners for selection/text notification

Great! Can you +r? Sorry for the spam.
Attachment #461990 - Flags: review?(masayuki)
Attachment #461990 - Flags: review?(masayuki) → review+

Updated

8 years ago
Blocks: 580388
tracking-fennec: --- → 2.0a1+

Updated

8 years ago
tracking-fennec: 2.0a1+ → ---
Created attachment 8364144 [details] [diff] [review]
part.2 Remove WM_USER_TSF_TEXTCHANGE from nsTextStore
Attachment #8364144 - Flags: review?(m_kato)
Comment on attachment 8364144 [details] [diff] [review]
part.2 Remove WM_USER_TSF_TEXTCHANGE from nsTextStore

Review of attachment 8364144 [details] [diff] [review]:
-----------------------------------------------------------------

good
Attachment #8364144 - Flags: review?(m_kato) → review+
https://hg.mozilla.org/mozilla-central/rev/973ac6481078
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.