544780 - [config] Add TDC = mail.dk

Status: RESOLVED FIXED

(Webtools :: ISPDB Database Entries, defect)

Description

[Jens Jensen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; da; rv:1.9.2) Gecko/20100115 Firefox/3.6
Build Identifier: 

Please add TDC to the Thunderbird auto config list.

Short description:
------------------
besked.com in the ISP database requires modification to specify 12 digit customer number for user name and addition of approx. 200 domains.


Detailed description:
---------------------
I have created the TDC e-mail domain besked.com in the ISP database, but was unable to specify the user name to be a 12 digit customer number. The data should look like this:

Incoming Server
Incoming type:		pop3
Incoming hostname:	pop3.mail.dk
Incoming port:		110
Incoming socket type:	plain
Username formula:	12 digit customer number
Incoming authentication: password-cleartext

Outgoing Server
Outgoing hostname: 	asmtp.mail.dk
Outgoing port: 		587
Outgoing socket type: 	plain
Username formula: 	12 digit customer number
Outgoing authentication: password-cleartext

The setup is described on this page (in danish):
http://kundeservice.tdc.dk/privat/faq.php?id=6005

The setup should be used for the domains listed in the attached file named TDC_email_domain.txt. So regardless of which domain from the list is used in the e-mail address, the servers pop3.mail.dk and asmtp.mail.dk should be used.

The list of e-mail domains is taken from webmail on this address (requires login): http://mail.tdconline.dk/?csref=_tdcforside_genveje_mail

Reproducible: Always

Comment 1

[Jens Jensen]

Attachment: List of TDC e-mail domains

Comment 2

[Ludovic Hirlimann [:Usul]]

Jens can you do that on ispdb.mozillamessaging.com please ?

Comment 3

[Jens Jensen]

Ludovic, do you suggest, that I get an OpenID and login to the ISP database and change the record? Otherwise I am not able to change it.

Comment 4

[Ludovic Hirlimann [:Usul]]

(In reply to comment #3)
> Ludovic, do you suggest, that I get an OpenID and login to the ISP database and
> change the record? Otherwise I am not able to change it.

That's one way to do it. The other is to do it the way it's done in bug 524045
.

Comment 5

[Jens Jensen]

Attachment: XML code to fix bug. User name fields left empty.

This is modified XML code from the ISP database. It should contain the necessary changes except for the user name fields, which I have left empty. Thunderbird should ask for the user names, and the user should enter 12 digit customer numbers (but they are identical for receive and send).

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 425805 [details]
XML code to fix bug. User name fields left empty.

See, this tiny edit box is why I prefer reviewing patches…  ;)

So, I'ld like to see a few changes.

There should really be an id in '<emailProvider id="">'.  I suggest 'mail.dk'.

The displayName should likely be longer than the displayShortName.  How about "Tele-Denmark Communications" instead of "TDC"?

The page at http://kundeservice.tdc.dk/privat/faq.php?id=6005 suggests that you should use "The email address you've created with your subscription." as your username, which seems like it would be easier than a 12-digit number, if it works.

And we'll need a copy of this file for each domain listed in it, but I could probably do that with a script before I check it in, so that we only have to review one copy.

Finally, it would be really nice if we could (get TDC to) use secure settings, so that their users didn't send their usernames and passwords in cleartext over the internet.

Thanks,
Blake.

Comment 7

[Jens Jensen]

Attachment: XML code to fix bug.

Code modified after first review.

Comment 8

[Jens Jensen]

(In reply to comment #6)
> (From update of attachment 425805 [details])
> See, this tiny edit box is why I prefer reviewing patches…  ;)

I thought Bugzilla would detect the file type automatically from the content. This time it should be ok.

> There should really be an id in '<emailProvider id="">'.  I suggest 'mail.dk'.

Added 'mail.dk'.

> The displayName should likely be longer than the displayShortName.  How about
> "Tele-Denmark Communications" instead of "TDC"?

They have only used "TDC" in Denmark for some years now. I changed it to "TDC/Tele Danmark".

> The page at http://kundeservice.tdc.dk/privat/faq.php?id=6005 suggests that you
> should use "The email address you've created with your subscription." as your
> username, which seems like it would be easier than a 12-digit number, if it
> works.

It works. Changed it.

> And we'll need a copy of this file for each domain listed in it, but I could
> probably do that with a script before I check it in, so that we only have to
> review one copy.

Please let me know, if I should provide a script, and in which language. I'll spend the necessary time to learn the language.

> Finally, it would be really nice if we could (get TDC to) use secure settings,
> so that their users didn't send their usernames and passwords in cleartext over
> the internet.

I am sure they will not change it.

Please let me know, if I should do more. I have tried but not been able to test the file.

Thanks,
Jens

Comment 9

[Jesper Kristensen]

I think it is a bad idea to use "Tele Danmark" as the don't use that name anywhere, and it is many years since they were called that. If the name must provide more detail, it could be "TDC (DK)" or something to take into account that a provider in another country might use the same three letter abbreviation.

Comment 10

[Jens Jensen]

Attachment: XML code to fix bug.

Changed displayName from "TDC/Tele Danmark" to "TDC (DK)" as I think Jesper is right.

Comment 11

[Jens Jensen]

Attachment: XML code to fix bug.

Changed outgoing servers addThisServer from false to true.

Please use a script to copy the XML file to one XML file for each domain. Please also tell me if you want me to make the script.

Comment 12

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 428709 [details]
XML code to fix bug.

Well, since we started working on this bug, Thunderbird has improved quite a bit, and now does MX lookups to find the config.  So, instead of listing all the domains here, we can have one file for the domain "fpo.mail.dk" and all of these domains will work.  (Well, all of them except for c.dk, which has an MX server of "egxin.mail.dk".  So we could list "fpo.mail.dk" and "egxin.mail.dk", and then everything would work.  :)

With that change, r=me.  And I'm going to ask BenB for the second review, since he often catches things that I miss.

Thanks,
Blake.

Comment 13

[Ben Bucksch (:BenB)]

bwinton: please remember: we make the MX lookup with the top level domain, so we need to put "mail.dk" in there as domain. "fpo.mail.dk" will *not* work.

Jens, please use proper linebreaks (View source in browser).

Comment 14

[Jens Jensen]

Attachment: Config file for mail.dk

I have deleted all domains but "mail.dk". If I have understood the latest reviewer comments correctly, this single file will cover both servers named "fpo.mail.dk" and "egxin.mail.dk".

Thank you Blake and Ben for the reviews.

Comment 15

[Ben Bucksch (:BenB)]

Comment on attachment 482089 [details]
Config file for mail.dk

- need v1.1 config file (I can convert)
- Please make an effort to find an SSL config, even if not published by the ISP

Please read https://developer.mozilla.org/en/Thunderbird/Autoconfiguration

Comment 16

[Ben Bucksch (:BenB)]

Also, asmtp.mail.dk just stalls after I greet it:
$ netcat asmtp.mail.dk 587
220 Welcome to asmtp.mail.dk!
EHLO mail.dk
[~1 minute]
421 4.4.2 service timed out.

That's not valid even if you say that I must be in their network. It can't just stall, at least it must say why it doesn't want to talk to me.

At the absolute minimum, we need to add <restriction>client-IP-address</>

Comment 17

[Jens Jensen]

Attachment: Config file for mail.dk

(In reply to comment #15)
> - need v1.1 config file (I can convert)
Done

> - Please make an effort to find an SSL config, even if not published by the ISP
Really made an effort, but SSL and STARTTLS are not working. STARTTLS works sometimes on asmtp.mail.dk port 587, but not always.

> Please read https://developer.mozilla.org/en/Thunderbird/Autoconfiguration
Done

(In reply to comment #16)
> Also, asmtp.mail.dk just stalls after I greet it:
> $ netcat asmtp.mail.dk 587
> 220 Welcome to asmtp.mail.dk!
> EHLO mail.dk
> [~1 minute]
> 421 4.4.2 service timed out.
> 
> That's not valid even if you say that I must be in their network. It can't just
> stall, at least it must say why it doesn't want to talk to me.

I get the same response even if I am on their network. But nevertheless it is possible to send mails via the server.

> At the absolute minimum, we need to add <restriction>client-IP-address</>

No. It does not help to be on the server owners network.

Comment 18

[Ben Bucksch (:BenB)]

> I get the same response even if I am on their network.

OK, could be the line ending. Some servers are picky about it.

Comment 19

[Ben Bucksch (:BenB)]

Authentication password-cleartext, otherwise looks good to me.
r=BenB with that.

Comment 20

[Jens Jensen]

Attachment: Config file for mail.dk

(In reply to comment #19)
> Authentication password-cleartext, otherwise looks good to me.

Fixed.

> r=BenB with that.

Does it mean reassign? I hope I am doing it right.

Comment 21

[Ben Bucksch (:BenB)]

Comment on attachment 482148 [details]
Config file for mail.dk

r= means "reviewed by ". Yes, you're doing it right, thanks! :-)

Comment 22

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 482148 [details]
Config file for mail.dk

Yeah, looks good to me.

Thanks for your work, Jens!

Comment 23

[Jens Jensen]

This bug has a reviewed and accepted solution, it is assigned but to nobody and with no activity for a couple of months. Is this normal?

Comment 24

[Ben Bucksch (:BenB)]

At TB: Yes.
For me: no.
Thanks for the reminder, I'll commit tomorrow.

Comment 25

[Ben Bucksch (:BenB)]

Commited as SVN Revision 79450
FIXED

Thanks, Jens!