545050 - Want macros for implementing reference counting without QI support

Status: RESOLVED WORKSFORME

(Core :: XPCOM, enhancement)

Description

[Zack Weinberg (:zwol)]

Sometimes you want to deCOMtaminate a class without also getting rid of reference counting, but right now, we don't have any macros that give you a canned AddRef/Release definition without also providing QueryInterface support.  Can we please add canned AddRef/Release macros, suitable for use with nsRefPtr<>, to nsAutoPtr.h or similar?

Comment 1

[Benjamin Smedberg]

NS_IMPL_ADDREF
NS_IMPL_RELEASE

So you just need a _DECL?

Comment 2

[Zack Weinberg (:zwol)]

That and maybe some documentation - it wasn't clear to me that it was safe to use NS_IMPL_ADDREF/RELEASE with non-COM interfaces (because of the NS_ASSERT_OWNINGTHREAD).  Also, do we *want* NS_ASSERT_OWNINGTHREAD for the general case of non-COM objects?

Comment 3

[Andrew McCreight [:mccr8]]

These macros exist now.  You can even cycle collect them.