5451 - Big file reads and writes are broken on NT.

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Wan-Teh Chang]

In the NT implementation of NSPR, PR_Read and
PR_Write don't work right on big files.  This
is because we are not setting the OffsetHigh
field of the OVERLAPPED structure, so OffsetHigh
always has the value of 0.

The reason we didn't notice this problem before
is probably that PR_Read and PR_Write are wrong
in the same way, so if a test (e.g., bigfile.c)
uses PR_Read and PR_Write, data written to the
wrong offset by PR_Write can still be read back
correctly by PR_Read.

I wrote two tests that use PR_Write with Win32
ReadFile or Win32 WriteFile with PR_Read, and
was able to verify this bug with a file offset
0x100000000.

Comment 1

[Wan-Teh Chang]

The two test programs are checked in: bigfile2.c and bigfile3.c.
They still need more work.

Comment 2

[Terry Weissman]

NSPR now has its own Bugzilla product.  Moving this bug to the NSPR product.

Comment 3

[Paul MacQuiddy]

phillip gone, removing him from qa contact, sorry for spam

Comment 4

[larryh (gone)]

re-assign to [e-mail]

Comment 5

[larryh (gone)]

Changed ntio.c to use the OffsetHigh member of the overlapped buffer.
new revision: 3.20.4.4; previous revision: 3.20.4.3

Comment 6

[larryh (gone)]

Fixed. Changes reviewed by wtc.