Closed Bug 545133 Opened 11 years ago Closed 11 years ago

Remove MOZ_VALGRIND from comm-central

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
trivial

Tracking

(thunderbird3.0 .4-fixed)

RESOLVED FIXED
Thunderbird 3.1b1
Tracking Status
thunderbird3.0 --- .4-fixed

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

(Keywords: fixed-seamonkey2.0.4)

Attachments

(1 file, 1 obsolete file)

No description provided.
Flags: in-testsuite-
Attached patch (Av1) Just copy it (obsolete) — Splinter Review
Attachment #425984 - Flags: review?(bugspam.Callek)
Attachment #425984 - Flags: approval-thunderbird3.0.2?
Attachment #425984 - Flags: approval-thunderbird3.0.2?
Attachment #425984 - Flags: review?(bugspam.Callek) → review+
Morphing this bug: I forgot to check this one :-<
Blocks: CcConfCleanup
No longer blocks: C191ConfSync, C192ConfSync
No longer depends on: 475876
OS: Linux → All
Hardware: x86 → All
Summary: Port |Bug 475876 - TM: add hooks so Valgrind works with the JIT without requiring --smc-check=all| to comm-central → Remove MOZ_VALGRIND from comm-central
Attachment #425984 - Attachment is obsolete: true
Attachment #426431 - Flags: review?(bugspam.Callek)
Attachment #426431 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 426431 [details] [diff] [review]
(Bv1) Just remove it
[Checkin: Comment 4 & 7]


http://hg.mozilla.org/comm-central/rev/ae2bc3f38c4a
Attachment #426431 - Attachment description: (Bv1) Just remove it → (Bv1) Just remove it [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 426431 [details] [diff] [review]
(Bv1) Just remove it
[Checkin: Comment 4 & 7]


"approval-thunderbird3.0.3=?":
Bug 475876 landed on m-1.9.1 too, Remove unsync'ed code.
Attachment #426431 - Flags: approval-thunderbird3.0.3?
Attachment #426431 - Flags: approval-thunderbird3.0.3? → approval-thunderbird3.0.4?
Attachment #426431 - Flags: approval-thunderbird3.0.4? → approval-thunderbird3.0.4+
Comment on attachment 426431 [details] [diff] [review]
(Bv1) Just remove it
[Checkin: Comment 4 & 7]

Ok, so the reason to take this is just that m-1.9.1 now has --enable-valgrind and we have --with-valgrind.
Comment on attachment 426431 [details] [diff] [review]
(Bv1) Just remove it
[Checkin: Comment 4 & 7]


http://hg.mozilla.org/releases/comm-1.9.1/rev/ccf93af32ef2
Attachment #426431 - Attachment description: (Bv1) Just remove it [Checkin: Comment 4] → (Bv1) Just remove it [Checkin: Comment 4 & 7]
Verified on the basis this landed and hasn't broken the builds.
You need to log in before you can comment on or make changes to this bug.