Remove MOZ_VALGRIND from comm-central

RESOLVED FIXED in Thunderbird 3.1b1

Status

MailNews Core
Build Config
--
trivial
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({fixed-seamonkey2.0.4})

Trunk
Thunderbird 3.1b1
fixed-seamonkey2.0.4
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird3.0 .4-fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

8 years ago
Created attachment 425984 [details] [diff] [review]
(Av1) Just copy it
Attachment #425984 - Flags: review?(bugspam.Callek)
Attachment #425984 - Flags: approval-thunderbird3.0.2?
Attachment #425984 - Flags: approval-thunderbird3.0.2?

Updated

8 years ago
Attachment #425984 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 2

8 years ago
Morphing this bug: I forgot to check this one :-<
Blocks: 513709
No longer blocks: 496236, 506493
No longer depends on: 475876
OS: Linux → All
Hardware: x86 → All
Summary: Port |Bug 475876 - TM: add hooks so Valgrind works with the JIT without requiring --smc-check=all| to comm-central → Remove MOZ_VALGRIND from comm-central
(Assignee)

Comment 3

8 years ago
Created attachment 426431 [details] [diff] [review]
(Bv1) Just remove it
[Checkin: Comment 4 & 7]
Attachment #425984 - Attachment is obsolete: true
Attachment #426431 - Flags: review?(bugspam.Callek)

Updated

8 years ago
Attachment #426431 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 4

8 years ago
Comment on attachment 426431 [details] [diff] [review]
(Bv1) Just remove it
[Checkin: Comment 4 & 7]


http://hg.mozilla.org/comm-central/rev/ae2bc3f38c4a
Attachment #426431 - Attachment description: (Bv1) Just remove it → (Bv1) Just remove it [Checkin: Comment 4]
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

8 years ago
Comment on attachment 426431 [details] [diff] [review]
(Bv1) Just remove it
[Checkin: Comment 4 & 7]


"approval-thunderbird3.0.3=?":
Bug 475876 landed on m-1.9.1 too, Remove unsync'ed code.
Attachment #426431 - Flags: approval-thunderbird3.0.3?
Attachment #426431 - Flags: approval-thunderbird3.0.3? → approval-thunderbird3.0.4?
Attachment #426431 - Flags: approval-thunderbird3.0.4? → approval-thunderbird3.0.4+
Comment on attachment 426431 [details] [diff] [review]
(Bv1) Just remove it
[Checkin: Comment 4 & 7]

Ok, so the reason to take this is just that m-1.9.1 now has --enable-valgrind and we have --with-valgrind.
(Assignee)

Comment 7

8 years ago
Comment on attachment 426431 [details] [diff] [review]
(Bv1) Just remove it
[Checkin: Comment 4 & 7]


http://hg.mozilla.org/releases/comm-1.9.1/rev/ccf93af32ef2
Attachment #426431 - Attachment description: (Bv1) Just remove it [Checkin: Comment 4] → (Bv1) Just remove it [Checkin: Comment 4 & 7]
(Assignee)

Updated

8 years ago
status-thunderbird3.0: --- → .4-fixed
Verified on the basis this landed and hasn't broken the builds.
Keywords: verified-thunderbird3.0

Updated

8 years ago
Keywords: fixed-seamonkey2.0.4
You need to log in before you can comment on or make changes to this bug.