545140 - [shipping] Use User.message_set for signoff accept/reject messages instead of custom solution

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Elmo, defect, P5)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Currently we use custom soluton for sending messages to the user. It would be nice to be able to use User.message_set, and with Django 1.2 it will become more flexible and fit our needs.

It's a bug with TM=Future.

Comment 1

[Axel Hecht [:Pike]]

Any reference on the upcoming changes?

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

oh, yea, sorry:

http://code.djangoproject.com/ticket/4604
http://code.djangoproject.com/changeset/11804

Comment 3

[Axel Hecht [:Pike]]

Reading the docs, I don't necessarily get where we could use that instead of something we did.

django-notifications sounded more like it, IMHO. See bug 538288.

Comment 4

[Axel Hecht [:Pike]]

http://docs.djangoproject.com/en/dev/ref/contrib/messages/ doesn't convince me.

Comment 5

[Peter Bengtsson [:peterbe]]

(In reply to comment #4)
> http://docs.djangoproject.com/en/dev/ref/contrib/messages/ doesn't convince
> me.

What's wrong/missing with the builtin? I quite like it. The old one used to not have support for levels but the new one looks pretty good for that.

Comment 6

[Axel Hecht [:Pike]]

Well, I just rip out the non-builtin as part of killing signoff1.

I don't think that the message framework does the right thing for the use cases. Think of having two tabs open, you sign off one one tab, then surf in the other to a bugzilla overview page, and it'll show a message that you signed off on something? At least that's how I understod the messages thing to work.

Comment 7

[Axel Hecht [:Pike]]

That message foo is gone, resolving WONTFIX.