545175 - synthesizeDrop needs dropEffect

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Neil Deakin]

Bug 462172 removed the setting of the dropEffect while trapDrag was called. But this is actually needed. Otherwise, the dropEffect will always be set to 'none' when the synthesized dragover event fires. This isn't the case though; a real dragover event will initialize the dropEffect from the keyboard state and 'move' is a more suitable default. This means that we can only test dragover handlers that explicitly set the dropEffect. 

Ideally, we should pass an argument to synthesizeDrop to set the dropEffect.

Comment 1

[Phil Lacy]

Thanks for looking at those I was not clear on what needed to be done for a test element. I didn't feel right about setting those in either spot, the test or the utility but you made it clear on what a tester would want.  I think passing it in would be the way to go in case the test is for an element that only allows one effect and not 'all'.

I can get that changed.

Comment 2

[Neil Deakin]

Attachment: need this for another bug so implement this argument

Comment 3

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/f345ceda03a8