Closed Bug 545225 Opened 10 years ago Closed 10 years ago

Sqlite configure test failing on 3.6.22

Categories

(Toolkit :: Storage, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2
Tracking Status
status1.9.2 --- .9-fixed

People

(Reporter: mozilla-bugs, Assigned: ehsan)

References

Details

Attachments

(1 file)

We just got sqlite 3.6.22-1 from debian into Lucid and the configure test failed.
Hmm, we got that test from the SQLite team, and ehsan ported it over to configure.
Component: Build Config → Storage
Product: Core → Toolkit
QA Contact: build-config → storage
(In reply to comment #0)
> We just got sqlite 3.6.22-1 from debian into Lucid and the configure test
> failed.

What do you mean by "failed"?  It crashed, or it got the wrong answer?
(In reply to comment #2)
> (In reply to comment #0)
> > We just got sqlite 3.6.22-1 from debian into Lucid and the configure test
> > failed.
> 
> What do you mean by "failed"?  It crashed, or it got the wrong answer?

Failed as in would not let the build continue:
checking for sqlite3 >= 3.6.22... yes
checking SQLITE_CFLAGS...  
checking SQLITE_LIBS... -lsqlite3  
checking for SQLITE_SECURE_DELETE support in system sqlite... no
configure: error: System Sqlite library is not compiled with SQLITE_SECURE_DELETE.
To be clear, your system SQLite is compiled with SQLITE_SECURE_DELETE, yes?
(In reply to comment #4)
> To be clear, your system SQLite is compiled with SQLITE_SECURE_DELETE, yes?

Here are the flags being passed:
-g -O2 -g -Wall -O2 -fno-strict-aliasing -DSQLITE_SECURE_DELETE
-DSQLITE_ENABLE_COLUMN_METADATA -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_RTREE=1"
CXXFLAGS="-g -O2 -g -Wall -O2 -fno-strict-aliasing -DSQLITE_SECURE_DELETE
-DSQLITE_ENABLE_COLUMN_METADATA -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_RTREE=1"
CPPFLAGS="" LDFLAGS="-Wl,-Bsymbolic-functions"
/build/buildd/sqlite3-3.6.22/./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir="\${prefix}/include" --mandir="\${prefix}/share/man"
--infodir="\${prefix}/share/info" --sysconfdir=/etc --localstatedir=/var
--libexecdir="\${prefix}/lib/sqlite3" --disable-maintainer-mode
--disable-dependency-tracking --disable-silent-rules --srcdir=. 
--with-tcl=/usr/lib/tcl8.5 --enable-threadsafe --enable-load-extension
For reference, the configure test src code can be found here:
http://mxr.mozilla.org/mozilla-central/source/configure.in#6261
Are you sure that's the same test code we sent you?  Because it is wrong.  The fix is to do a global replace: s/sizeof(zBuf)/3072/g.
attachment 414114 [details] is what I got from your file transfer to me, and that also has the sizeof(zBuf) stuff in it.

ehsan - do you want to patch this?  If so, rs=me on making a new const with that magic number, and using it instead.
Oh, that got broken in the autoconfiscation, and I missed it. :-/ (ehsan took out the [] rather than deal with m4 escaping insanity).
Attached patch Patch (v1)Splinter Review
Arghh, sorry, this is totally my fault.  The fix is simple (and hopefully correct!).

Asking Ted for review/sanity check.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #426118 - Flags: review?(ted.mielczarek)
Attachment #426118 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/3f7a67c9d63a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Comment on attachment 426118 [details] [diff] [review]
Patch (v1)

I think this fix on the 1.9.2 branch is needed since bug 445164 just landed on mozilla-1.9.2 and now configure fails.
Attachment #426118 - Flags: approval1.9.2.8?
Comment on attachment 426118 [details] [diff] [review]
Patch (v1)

a=LegNeato for 1.9.2.8. Please only land this on mozilla-1.9.2 default, *not* the relbranch.
Attachment #426118 - Flags: approval1.9.2.8? → approval1.9.2.8+
You need to log in before you can comment on or make changes to this bug.