545225 - Sqlite configure test failing on 3.6.22

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Micah Gersten]

We just got sqlite 3.6.22-1 from debian into Lucid and the configure test failed.

Comment 1

[Shawn Wilsher :sdwilsh]

Hmm, we got that test from the SQLite team, and ehsan ported it over to configure.

Comment 2

[D. Richard Hipp]

(In reply to comment #0)
> We just got sqlite 3.6.22-1 from debian into Lucid and the configure test
> failed.

What do you mean by "failed"?  It crashed, or it got the wrong answer?

Comment 3

[Micah Gersten]

(In reply to comment #2)
> (In reply to comment #0)
> > We just got sqlite 3.6.22-1 from debian into Lucid and the configure test
> > failed.
> 
> What do you mean by "failed"?  It crashed, or it got the wrong answer?

Failed as in would not let the build continue:
checking for sqlite3 >= 3.6.22... yes
checking SQLITE_CFLAGS...  
checking SQLITE_LIBS... -lsqlite3  
checking for SQLITE_SECURE_DELETE support in system sqlite... no
configure: error: System Sqlite library is not compiled with SQLITE_SECURE_DELETE.

Comment 4

[Shawn Wilsher :sdwilsh]

To be clear, your system SQLite is compiled with SQLITE_SECURE_DELETE, yes?

Comment 5

[Micah Gersten]

(In reply to comment #4)
> To be clear, your system SQLite is compiled with SQLITE_SECURE_DELETE, yes?

Here are the flags being passed:
-g -O2 -g -Wall -O2 -fno-strict-aliasing -DSQLITE_SECURE_DELETE
-DSQLITE_ENABLE_COLUMN_METADATA -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_RTREE=1"
CXXFLAGS="-g -O2 -g -Wall -O2 -fno-strict-aliasing -DSQLITE_SECURE_DELETE
-DSQLITE_ENABLE_COLUMN_METADATA -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_RTREE=1"
CPPFLAGS="" LDFLAGS="-Wl,-Bsymbolic-functions"
/build/buildd/sqlite3-3.6.22/./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir="\${prefix}/include" --mandir="\${prefix}/share/man"
--infodir="\${prefix}/share/info" --sysconfdir=/etc --localstatedir=/var
--libexecdir="\${prefix}/lib/sqlite3" --disable-maintainer-mode
--disable-dependency-tracking --disable-silent-rules --srcdir=. 
--with-tcl=/usr/lib/tcl8.5 --enable-threadsafe --enable-load-extension

Comment 6

[Shawn Wilsher :sdwilsh]

For reference, the configure test src code can be found here:
http://mxr.mozilla.org/mozilla-central/source/configure.in#6261

Comment 7

[D. Richard Hipp]

Are you sure that's the same test code we sent you?  Because it is wrong.  The fix is to do a global replace: s/sizeof(zBuf)/3072/g.

Comment 8

[Shawn Wilsher :sdwilsh]

attachment 414114 [details] is what I got from your file transfer to me, and that also has the sizeof(zBuf) stuff in it.

ehsan - do you want to patch this?  If so, rs=me on making a new const with that magic number, and using it instead.

Comment 9

[(not currently active) Ted Mielczarek]

Oh, that got broken in the autoconfiscation, and I missed it. :-/ (ehsan took out the [] rather than deal with m4 escaping insanity).

Comment 10

[(no longer active)]

Attachment: Patch (v1)

Arghh, sorry, this is totally my fault.  The fix is simple (and hopefully correct!).

Asking Ted for review/sanity check.

Comment 11

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/3f7a67c9d63a

Comment 12

[Micah Gersten]

Comment on attachment 426118 [details] [diff] [review]
Patch (v1)

I think this fix on the 1.9.2 branch is needed since bug 445164 just landed on mozilla-1.9.2 and now configure fails.

Comment 13

[LegNeato]

Comment on attachment 426118 [details] [diff] [review]
Patch (v1)

a=LegNeato for 1.9.2.8. Please only land this on mozilla-1.9.2 default, *not* the relbranch.

Comment 14

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/228d5ccfddc3