545261 - Remove the "yikes! spinning on a line over 1000 times!" abort

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Let's remove the "yikes! spinning on a line over 1000 times!" abort.

This debug-build-only abort was once marginally useful for helping to distinguish hangs.  But now it's just catching false positives (testcases that don't actually cause opt builds don't hang), annoying me and tomcat.

See e.g. bug 493910 (which has a testcase) and bug 505139 (which involves http://direkizle.net/alacakaranlik-twilight-turkce-dublaj.html)

Comment 1

[Jesse Ruderman]

http://hg.mozilla.org/mozilla-central/annotate/e594e7778297/layout/generic/nsBlockFrame.cpp#l3390

Comment 2

[Timothy Nikkel (:tnikkel)]

Bug 539409 is also same abort, although the bug doesn't mention that.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What real testcases trigger this and then finish?  That seems really broken.

Comment 4

[Ed Morley [:emorley]]

Is this still wanted?

Comment 5

[Ed Morley [:emorley]]

Attachment: Remove the debug "yikes! spinning on a line over 1000 times!" abort

Comment 6

[Ed Morley [:emorley]]

Attachment: Remove the debug "yikes! spinning on a line over 1000 times!" abort

Actually remember to qrefresh...

Comment 7

[Ed Morley [:emorley]]

http://dev.philringnalda.com/tbpl/?tree=Try&rev=f88432556f2e

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Let's change it to an assertion instead of an abort.

Comment 9

[Ed Morley [:emorley]]

Attachment: Change "yikes! spinning 1000 times!" abort to an assertion

Changes the abort to an assertion.

Roc, is this the way you meant? (ie leaving the ListTag but removing the printf?)

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Why not just remove it, as in attachment 530867 [details] [diff] [review]?  We don't have this sort of code for most other loops, and debugging hangs of this sort generally isn't that hard.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 530867 [details] [diff] [review]
Remove the debug "yikes! spinning on a line over 1000 times!" abort

Review of attachment 530867 [details] [diff] [review]:
-----------------------------------------------------------------

ok

Comment 12

[Ed Morley [:emorley]]

Reverting back to the patch in comment 6, which removes the abort completely.

Roc, thanks for the review :-)

Comment 13

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/6f092fa95ba1