Last Comment Bug 545261 - Remove the "yikes! spinning on a line over 1000 times!" abort
: Remove the "yikes! spinning on a line over 1000 times!" abort
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla6
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on:
Blocks: 505139
  Show dependency treegraph
 
Reported: 2010-02-09 16:29 PST by Jesse Ruderman
Modified: 2011-08-24 03:34 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove the debug "yikes! spinning on a line over 1000 times!" abort (1.25 KB, patch)
2011-05-07 12:04 PDT, Ed Morley [:emorley]
no flags Details | Diff | Review
Remove the debug "yikes! spinning on a line over 1000 times!" abort (1.93 KB, patch)
2011-05-07 12:07 PDT, Ed Morley [:emorley]
roc: review+
Details | Diff | Review
Change "yikes! spinning 1000 times!" abort to an assertion (1.11 KB, patch)
2011-05-09 05:38 PDT, Ed Morley [:emorley]
no flags Details | Diff | Review

Description Jesse Ruderman 2010-02-09 16:29:02 PST
Let's remove the "yikes! spinning on a line over 1000 times!" abort.

This debug-build-only abort was once marginally useful for helping to distinguish hangs.  But now it's just catching false positives (testcases that don't actually cause opt builds don't hang), annoying me and tomcat.

See e.g. bug 493910 (which has a testcase) and bug 505139 (which involves http://direkizle.net/alacakaranlik-twilight-turkce-dublaj.html)
Comment 2 Timothy Nikkel (:tnikkel) 2010-02-09 16:43:50 PST
Bug 539409 is also same abort, although the bug doesn't mention that.
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2010-02-09 17:35:27 PST
What real testcases trigger this and then finish?  That seems really broken.
Comment 4 Ed Morley [:emorley] 2011-04-10 19:06:28 PDT
Is this still wanted?
Comment 5 Ed Morley [:emorley] 2011-05-07 12:04:16 PDT
Created attachment 530866 [details] [diff] [review]
Remove the debug "yikes! spinning on a line over 1000 times!" abort
Comment 6 Ed Morley [:emorley] 2011-05-07 12:07:33 PDT
Created attachment 530867 [details] [diff] [review]
Remove the debug "yikes! spinning on a line over 1000 times!" abort

Actually remember to qrefresh...
Comment 7 Ed Morley [:emorley] 2011-05-08 06:42:19 PDT
http://dev.philringnalda.com/tbpl/?tree=Try&rev=f88432556f2e
Comment 8 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-05-09 02:36:36 PDT
Let's change it to an assertion instead of an abort.
Comment 9 Ed Morley [:emorley] 2011-05-09 05:38:02 PDT
Created attachment 531025 [details] [diff] [review]
Change "yikes! spinning 1000 times!" abort to an assertion

Changes the abort to an assertion.

Roc, is this the way you meant? (ie leaving the ListTag but removing the printf?)
Comment 10 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-05-09 06:58:33 PDT
Why not just remove it, as in attachment 530867 [details] [diff] [review]?  We don't have this sort of code for most other loops, and debugging hangs of this sort generally isn't that hard.
Comment 11 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-05-09 17:31:15 PDT
Comment on attachment 530867 [details] [diff] [review]
Remove the debug "yikes! spinning on a line over 1000 times!" abort

Review of attachment 530867 [details] [diff] [review]:
-----------------------------------------------------------------

ok
Comment 12 Ed Morley [:emorley] 2011-05-09 18:00:29 PDT
Reverting back to the patch in comment 6, which removes the abort completely.

Roc, thanks for the review :-)

Note You need to log in before you can comment on or make changes to this bug.