Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove the "yikes! spinning on a line over 1000 times!" abort

RESOLVED FIXED in mozilla6

Status

()

Core
Layout
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: emorley)

Tracking

Trunk
mozilla6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

8 years ago
Let's remove the "yikes! spinning on a line over 1000 times!" abort.

This debug-build-only abort was once marginally useful for helping to distinguish hangs.  But now it's just catching false positives (testcases that don't actually cause opt builds don't hang), annoying me and tomcat.

See e.g. bug 493910 (which has a testcase) and bug 505139 (which involves http://direkizle.net/alacakaranlik-twilight-turkce-dublaj.html)
(Reporter)

Comment 1

8 years ago
http://hg.mozilla.org/mozilla-central/annotate/e594e7778297/layout/generic/nsBlockFrame.cpp#l3390
Bug 539409 is also same abort, although the bug doesn't mention that.
What real testcases trigger this and then finish?  That seems really broken.
Blocks: 505139
(Assignee)

Comment 4

6 years ago
Is this still wanted?
(Assignee)

Comment 5

6 years ago
Created attachment 530866 [details] [diff] [review]
Remove the debug "yikes! spinning on a line over 1000 times!" abort
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #530866 - Flags: review?(roc)
(Assignee)

Comment 6

6 years ago
Created attachment 530867 [details] [diff] [review]
Remove the debug "yikes! spinning on a line over 1000 times!" abort

Actually remember to qrefresh...
Attachment #530866 - Attachment is obsolete: true
Attachment #530867 - Flags: review?(roc)
Attachment #530866 - Flags: review?(roc)
(Assignee)

Comment 7

6 years ago
http://dev.philringnalda.com/tbpl/?tree=Try&rev=f88432556f2e
Let's change it to an assertion instead of an abort.
(Assignee)

Updated

6 years ago
Summary: Remove the "yikes! spinning on a line over 1000 times!" abort → Change the "yikes! spinning on a line over 1000 times!" abort to an assertion
(Assignee)

Comment 9

6 years ago
Created attachment 531025 [details] [diff] [review]
Change "yikes! spinning 1000 times!" abort to an assertion

Changes the abort to an assertion.

Roc, is this the way you meant? (ie leaving the ListTag but removing the printf?)
Attachment #530867 - Attachment is obsolete: true
Attachment #531025 - Flags: review?(roc)
Attachment #530867 - Flags: review?(roc)
Why not just remove it, as in attachment 530867 [details] [diff] [review]?  We don't have this sort of code for most other loops, and debugging hangs of this sort generally isn't that hard.
Comment on attachment 530867 [details] [diff] [review]
Remove the debug "yikes! spinning on a line over 1000 times!" abort

Review of attachment 530867 [details] [diff] [review]:
-----------------------------------------------------------------

ok
Attachment #530867 - Flags: review+
(Assignee)

Updated

6 years ago
Attachment #531025 - Attachment is obsolete: true
Attachment #531025 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Attachment #530867 - Attachment is obsolete: false
(Assignee)

Comment 12

6 years ago
Reverting back to the patch in comment 6, which removes the abort completely.

Roc, thanks for the review :-)
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/6f092fa95ba1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Summary: Change the "yikes! spinning on a line over 1000 times!" abort to an assertion → Remove the "yikes! spinning on a line over 1000 times!" abort
Version: Trunk → Other Branch
Version: Other Branch → Trunk
You need to log in before you can comment on or make changes to this bug.