545265 - On panels, noautohide causes noautofocus to not work

Status: REOPENED

(Core :: XUL, defect)

Description

[Benjamin Stover (:stechz)]

This does not affect Mac platform, confirmed on Linux.

If you open a popup with noautofocus="true" and noautohide="true", the popup will steal focus from the main window.  Oddly enough, if you dynamically set noautohide to true after the first time the popup is shown, this problem goes away.

To reproduce (with DOM inspector):
1) Open firefox
2) Before anything else, go to DOM inspector and find identity-popup under main popupset.  Set noautohide=true.
3) Click identity popup handler

Behavior: focus is stolen from Firefox (when it shouldn't be)

Comment 1

[Neil Deakin]

If this is Linux only, this is likely bug 526941.

Comment 2

[Benjamin Stover (:stechz)]

That bug sounds slightly different, in that (AFAICT) the elements *inside* the popup aren't properly focused.  For this bug, focus is taken away from the main window even though noautofocus is true.

The root cause may be the same though.

Comment 3

[Neil Deakin]

Is this bug still an issue?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #3)
> Is this bug still an issue?

This is still an issue for me on changeset http://hg.mozilla.org/mozilla-central/rev/6dca94a53967.

If I install Compiz on my Linux box, the bug dissapears so it seems related to Metacity only.

Comment 5

[Ed Lee :Mardak]

Thanks for the workaround in comment #0. People were running into this on Ubuntu:
http://www.youtube.com/watch?v=npjDFBcb7g4

+++ b/awesomeBarHD/bootstrap.js
@@ -1020,4 +1020,3 @@ function addAwesomeBarHD(window) {
   tabPanel.setAttribute("noautofocus", true);
-  tabPanel.setAttribute("noautohide", true);
 
   tabPanel.style.MozWindowShadow = "none";
@@ -1112,0 +1111,6 @@ function addAwesomeBarHD(window) {
+  // Dynamically set noautohide to avoid bug 545265
+  tabPanel.addEventListener("popupshowing", function() {
+    if (!tabPanel.hasAttribute("noautohide"))
+      tabPanel.setAttribute("noautohide", true);
+  }, false);

Comment 6

[Ed Lee :Mardak]

Actually, we ended up fixing it with one-time event listener that removes itself on first popupshowing:
https://github.com/mozilla/prospector/commit/f37a573cc0115f7d57536110e284778679d50708

Comment 7

[Ben Bucksch (:BenB)]

> Is this bug still an issue?

Yes, I just ran into it.

Comment 8

[Neil Deakin]

This sounds like the metacity bug https://bugzilla.gnome.org/show_bug.cgi?id=621848

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Neil Deakin from comment #8)
> This sounds like the metacity bug
> https://bugzilla.gnome.org/show_bug.cgi?id=621848

That's it. https://github.com/tthurman/Metacity/pull/1/files fix it but I have been unable to upstream it.

Comment 10

[:Paolo Amadini]

Neil, is there anything we can do to work around this bug on our side?

This bug happens after applying my patch in bug 1320361 that makes the notification panel disappear properly when the window is minimized, and it's in fact the reverse of the workaround in comment 5.

Comment 11

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 12

[Dão Gottwald [:dao]]

This bug is referenced here, so presumably it's still an issue: https://searchfox.org/mozilla-central/rev/bf4def01bf8f6ff0d18f02f2d7e9efc73e12c63f/browser/base/content/browser.js#189