Closed Bug 545297 Opened 14 years ago Closed 14 years ago

don't add an extra reference to GtkPlug::socket_window with versions of GTK that already add a reference

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Linux
defect
Not set
normal

Tracking

(status1.9.2 .4-fixed)

RESOLVED FIXED
mozilla1.9.3a4
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: karlt, Assigned: karlt)

References

Details

(Whiteboard: [fixed-lorentz])

Attachments

(1 file)

In bug 539897 the refcount of the GtkPlug::socket_window was incremented to work around a missing increment in GTK.  Now that recent versions of GTK already correctly increment, we need to stop incrementing again with these versions.

http://git.gnome.org/browse/gtk+/commit/?id=beddf67e562e1670d692cb9ba0a2546713cc80fc
GTK 2.18.7 is the first release to contain the above commit.
http://mail.gnome.org/archives/gtk-devel-list/2010-February/msg00026.html
Attached patch patchSplinter Review
Attachment #434781 - Flags: review?(jones.chris.g)
Attachment #434781 - Flags: review?(jones.chris.g) → review+
http://hg.mozilla.org/mozilla-central/rev/4c43ce36af6e
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
http://hg.mozilla.org/projects/firefox-lorentz/rev/05f292fe7c2f
merged to 1.9.2 for 1.9.2.4
Whiteboard: [fixed-lorentz]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: