All users were logged out of Bugzilla on October 13th, 2018

don't add an extra reference to GtkPlug::socket_window with versions of GTK that already add a reference

RESOLVED FIXED in mozilla1.9.3a4

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

Trunk
mozilla1.9.3a4
x86
Linux
Points:
---

Firefox Tracking Flags

(status1.9.2 .4-fixed)

Details

(Whiteboard: [fixed-lorentz])

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
In bug 539897 the refcount of the GtkPlug::socket_window was incremented to work around a missing increment in GTK.  Now that recent versions of GTK already correctly increment, we need to stop incrementing again with these versions.

http://git.gnome.org/browse/gtk+/commit/?id=beddf67e562e1670d692cb9ba0a2546713cc80fc
(Assignee)

Comment 1

9 years ago
GTK 2.18.7 is the first release to contain the above commit.
http://mail.gnome.org/archives/gtk-devel-list/2010-February/msg00026.html
(Assignee)

Comment 2

9 years ago
Created attachment 434781 [details] [diff] [review]
patch
Attachment #434781 - Flags: review?(jones.chris.g)
Attachment #434781 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/mozilla-central/rev/4c43ce36af6e
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4

Comment 4

9 years ago
http://hg.mozilla.org/projects/firefox-lorentz/rev/05f292fe7c2f
merged to 1.9.2 for 1.9.2.4
status1.9.2: --- → .4-fixed
Whiteboard: [fixed-lorentz]
You need to log in before you can comment on or make changes to this bug.