545383 - Tabbed browser doesn't tell session restore to disable undo close tab

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[[e-mail]]

The tabbed browser's removeTab method has an aDisableUndo argument but that only disables the tabbrowser's undo and not the session restore undo close tab.

This has become significant because of bug 530735 which allows the session restore undo close tab to operate on the tab.

Comment 1

[[e-mail]]

Attachment: Proposed patch

The session store code already expects a UIEvent with a detail anyway.

Comment 2

[[e-mail]]

Misak, I don't suppose that this is something that you can write a test for?

Comment 3

[Misak Khachatryan]

Comment on attachment 426231 [details] [diff] [review]
Proposed patch

I think i should add code to handle aDisableUndo in sessionrestore.

Comment 4

[[e-mail]]

It's already there in line 419 of nsSessionStore.js:
if (!aEvent.detail)
  this.onTabClose(win, aEvent.originalTarget);
Its purpose was originally to deal with switching tabs between browsers, where you also want to disable undo.

Comment 5

[Misak Khachatryan]

Ah, I'm starring to the code two days to find how it should work. Thanks for explanation :)

Comment 6

[[e-mail]]

(In reply to comment #5)
> Ah, I'm starring to the code two days to find how it should work. Thanks for
> explanation :)
No, starring is what you do to non-green Tinderboxes ;-) (Mind you, many developers seem to be staring at the non-green Tinderboxes, not that it helps!)

Comment 7

[[e-mail]]

Whoops, forgot to update the bug when I pushed the patch a couple of weeks ago.

Pushed changeset b4e566c1043b to comm-central.