545395 - Prompt user when closing with more than one tab open

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

The Fennec "x" (far right on toolbar) closes the entire application - right away. The "x" is confused a lot with the "x" to close a single tab and the "x" to stop pageloads.

Because of the confusion, we get many reports of "I clicked the 'x' by mistake and closed the app". We can add a "You are about to close %S tabs. Are you sure you want to continue?" like Firefox desktop does.

See tabbrowser.properties for strings.

Comment 1

[Fabrice Desré]

Not saying that we should not add such a prompt, but session restore will also help with these "oops I closed the full browser" issues.

Comment 2

[Madhava Enros [:madhava]]

They're both useful.  Session restore helps with slips _and_ mistakes, whereas the prompt is extra effective specifically for slips.

See: http://www.interaction-design.org/encyclopedia/human_error_slips_and_mistakes.html

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch builds on bug 551889

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

screenshot: http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-promptonclose.png

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 433573 [details] [diff] [review]
patch

That's a very nice functionality.
I already know someone which is going to be happy to not close his window when he tried to close a tab!

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/472052587a79

Comment 7

[Aakash Desai [:aakashd]]

verified on desktop builds, but I need to hold off on verifying this bug until https://bugzilla.mozilla.org/show_bug.cgi?id=555817 is fixed.

Comment 8

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=7099 updated to regression test this bug.

Comment 9

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=9702 updated for l10n string guide

Also, thanks to the fix in bug 555817

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.3pre) Gecko/20100331 Namoroka/3.6.3pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.3a4pre) Gecko/20100331 Namoroka/3.7a4pre Fennec/1.1a2pre