Closed Bug 545431 Opened 10 years ago Closed 10 years ago

Make xulrunner support MOZ_PKG_PRETTYNAMES

Categories

(Toolkit Graveyard :: Build Config, defect, P3)

x86_64
Linux
defect

Tracking

(status1.9.2 .4-fixed, status1.9.1 .10-fixed)

RESOLVED FIXED
Tracking Status
status1.9.2 --- .4-fixed
status1.9.1 --- .10-fixed

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(4 files, 1 obsolete file)

Attached patch Proposed fix (obsolete) — Splinter Review
Working on bug 497803 I get the following error:

make -f client.mk sdk
....
cd ../../dist && gtar -c --owner=0 --group=0 --numeric-owner --mode="go-w" -f - xulrunner-sdk | bzip2 -vf > linux-i686/en-US/xulrunner-3.6.sdk.tar.bz2
/bin/sh: linux-i686/en-US/xulrunner-3.6.sdk.tar.bz2: No such file or directory

Seems like make-sdk target requires additional step.

Please review the following patch and consider to land it to branches too.
Attachment #426268 - Flags: review?(ted.mielczarek)
Assignee: nobody → raliiev
Attachment #426268 - Flags: review?(ted.mielczarek) → review+
Summary: Xulrunner SDK makefil fix → Xulrunner SDK makefile fix
Ted,

thanks a lot for your review.

I would like to retitle this bug and obsolete the patch with another one.

Xulrunner uses its own directory layout and naming convention for releases (when MOZ_PKG_PRETTYNAMES is set). See the current directory layout:
http://releases.mozilla.org/pub/mozilla.org/xulrunner/releases/1.9.2rc1/

Please review the following patch and consider to land it to branches.
Summary: Xulrunner SDK makefile fix → Make xulrunner support MOZ_PKG_PRETTYNAMES
Attachment #426268 - Attachment is obsolete: true
Attachment #426649 - Flags: review?(ted.mielczarek)
You are of course free to do what you like with your own bugs.
Keywords: checkin-needed
Sorry, queue is backed up a bit again. Will tend to it monday or so.
(In reply to comment #5)
> Sorry, queue is backed up a bit again. Will tend to it monday or so.
ping?
Comment on attachment 426649 [details] [diff] [review]
Proposed patch v2

Ok, this looks fine, sorry for the delay.
Attachment #426649 - Flags: review?(ted.mielczarek) → review+
Rail pointed me at: https://wiki.mozilla.org/Releases/Firefox_3.5.7/BuildNotes#XULRunner_build

which is the notes on how the directory structure is currently generated by hand(!)
Priority: -- → P3
Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/cdd4b50a322f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
1) Ted: thanks for landing this on mozilla-central.

2) We need this landed on each branch where we are providing xulrunner releases, hence the requests for 191, 192.
this time with the flags, lost during mid-air-collision.
blocking1.9.1: --- → ?
blocking1.9.2: --- → ?
Not blocking, ask for approval on the patch if you want to get it in.
blocking1.9.1: ? → ---
blocking1.9.2: ? → ---
I think this bug regressed the naming of the SDKs. Previously we had 
  xulrunner-1.9.3a3pre.en-US.mac-i386.sdk.tar.bz2
and now its
  xulrunner.en-US.mac-i386.sdk.tar.bz2

Looks like 
  http://hg.mozilla.org/mozilla-central/rev/cdd4b50a322f#l2.22
left out a -$(MOZ_PKG_VERSION).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #430520 - Flags: review?(ted.mielczarek)
Attachment #430520 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 430520 [details] [diff] [review]
fix-mac-sdk-name.diff

http://hg.mozilla.org/mozilla-central/rev/e93efbc87c88

Verifying this fix relies on bug 552339 giving us back XULRunner nightlies.
Attachment #426649 - Flags: approval1.9.2.3?
Attachment #426649 - Flags: approval1.9.1.10?
Attachment #430520 - Flags: approval1.9.2.3?
Attachment #430520 - Flags: approval1.9.1.10?
(In reply to comment #15)
> (From update of attachment 430520 [details] [diff] [review])
> http://hg.mozilla.org/mozilla-central/rev/e93efbc87c88
> 
> Verifying this fix relies on bug 552339 giving us back XULRunner nightlies.

In other words, everything is OK after applying both patches.
Attachment #426649 - Flags: approval1.9.2.3?
Attachment #426649 - Flags: approval1.9.2.3-
Attachment #426649 - Flags: approval1.9.1.10?
Attachment #426649 - Flags: approval1.9.1.10-
Comment on attachment 430520 [details] [diff] [review]
fix-mac-sdk-name.diff

Please get us a combined branch-merged patch of what you want us to approve for branches.
Attachment #430520 - Flags: approval1.9.2.3?
Attachment #430520 - Flags: approval1.9.2.3-
Attachment #430520 - Flags: approval1.9.1.10?
Attachment #430520 - Flags: approval1.9.1.10-
Attachment #436427 - Flags: review?(ted.mielczarek)
Attachment #436428 - Flags: review?(ted.mielczarek)
You don't need re-review unless you've made significant changes. Just merging two patches into one is fine. If that's all you had to do, then feel free to simply request approval on these pathes.
Attachment #436427 - Flags: review?(ted.mielczarek) → approval1.9.1.10?
Attachment #436428 - Flags: review?(ted.mielczarek) → approval1.9.2.4?
Attachment #436427 - Flags: approval1.9.1.10? → approval1.9.1.10+
Comment on attachment 436428 [details] [diff] [review]
combined patch for 1.9.2

a=beltzner for 1.9.2.4 and 1.9.1.10
Attachment #436428 - Flags: approval1.9.2.4? → approval1.9.2.4+
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.