Closed Bug 545516 Opened 15 years ago Closed 14 years ago

Fixes to performance snapshot

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dietrich, Assigned: dietrich)

References

(
URL
)

Details

(Whiteboard: [talos])

Attachments

(1 file, 1 obsolete file)

update
10.06 KB, patch
rhelmer
: review+
Details | Diff | Splinter Review
fixed some bugs, cleaned up the layout, got it ready to switch to 3.6 as the stable branch.
Attached patch v1 (obsolete) — — Splinter Review
Assignee: nobody → dietrich
Attachment #426350 - Flags: review?(catlee)
Attachment #426350 - Flags: review?(catlee) → review+
Thanks for review. Do I need special privs to check into the repo, or are mozilla-central commit privs enough?
(no update to this bug in > 2 years) (In reply to comment #2) > Thanks for review. Do I need special privs to check into the repo, or are > mozilla-central commit privs enough? deitrich: 1) Has this 27month old patch bit-rotted? Also, can you add FF4.0 while you are at it? :-) 2) Not sure about commit privs. 3) Does landing this need to be coordinated with a downtime?
(In reply to comment #3) > (no update to this bug in > 2 years) DUH! my bad, I was editing another bug from 2008 and snafu'd. Feb2010 is only 3 months ago. Sorry about that. Apart from the age of the patch, rest of my questions still apply. > (In reply to comment #2) > > Thanks for review. Do I need special privs to check into the repo, or are > > mozilla-central commit privs enough? > > deitrich: > > 1) Has this 27month old patch bit-rotted? Also, can you add FF4.0 while you are > at it? :-) > > 2) Not sure about commit privs. > > 3) Does landing this need to be coordinated with a downtime?
not working on this at the moment, unassigning.
Assignee: dietrich → nobody
I'm on buildduty next week - is this patch ready to land? If it's ready I can try to schedule a short downtime to update Talos with this.
Whiteboard: [talos][buildduty]
This patch should be updated to make 3.6 the stable branch to compare against. If I can figure out how to pull this code, I'll update it. Cloning the graphs repo doesn't pull this code for some reason...
(In reply to comment #7) > This patch should be updated to make 3.6 the stable branch to compare against. > If I can figure out how to pull this code, I'll update it. Cloning the graphs > repo doesn't pull this code for some reason... did you update your pull to the 1.0 branch?
Ok, pulled the source correctly, thanks for the tip. However, looks like the data format has changed (or the location?). testdata.js now only has Tp4 data. I need to find the rest of the test data....
Hm, looks like there's mobile Ts data too. But that's it. Weird.
I think that Catlee will know more how to connect you with that data.
I think that Alice will know better than I!
Dietrich it's not really clear what you're needing for this patch. What test data are you trying to locate? What needs to be updated? The original patch was for snapshot.js, what is this testdata.js you refer to?
Also I'm re-assigning it to you since it's not something that anyone in Releng is working on and only needs our attention to review/coordinate landing.
Assignee: nobody → dietrich
The performance dashboard (http://graphs.mozilla.org/dashboard/, which suddenly is empty?!) has a file testdata.js which *was* populated every 5 minutes (iirc) with a summary of test data. The perf snapshot (http://graphs.mozilla.org/dashboard/snapshot/) also used it for it's data source. When I tried to update the patch for this bug, I noticed that a bunch of test data was no longer present in the testdata.js file. That was a few days ago. And just now the file seems to be empty! So, I need to figure out where that testdata.js file is coming from (er, or not, anymore). Cc'ing Johnath since he made the dashboard.
Whiteboard: [talos][buildduty] → [talos]
Is RelEng the right component for this? IIUC this should be webdev:Talos or similar.
URL: http://graphs.mozilla.org/dashboard/
Summary: bug fixes and other changes to the performance snapshot → Fixes to performance dashboard
Attached patch update — — Splinter Review
* updated original patch * updated to still work properly as new tests/branches/oses are added (excepting the branch diff bits) The testdata.js file itself is out of date - doesn't include contemporary tests/branches. Rob, do you know what generates that file?
Attachment #426350 - Attachment is obsolete: true
Attachment #527588 - Flags: review?(rhelmer)
Attachment #527588 - Flags: review?(rhelmer) → review+
http://hg.mozilla.org/graphs/rev/8a38da488903
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Summary: Fixes to performance dashboard → Fixes to performance snapshot
This was pushed to production in bug 653358.
Depends on: 653358
Product: mozilla.org → Release Engineering
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/1f7b30eb6998f20de7f5378eeb9751dbc2d19654 Bug 545516 - Fixes to performance dashboard (r=rhelmer) --HG-- branch : 1.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: