545539 - create new osx10.6 64bit ref image and ref docs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

...and work-in-progress docs are:
https://wiki.mozilla.org/Mac:64BitRelEng
https://wiki.mozilla.org/ReferencePlatforms/Mac-10.6

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Grabbing, as I'm working on this with Josh.

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

ok, i've now installed everything listed on https://wiki.mozilla.org/Mac:64BitRelEng.

Whats next?

Comment 3

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Pushing over to bear, with thanks!!

Comment 4

[Mike Taylor [:bear]]

I've done a stock build with configs/mozilla2-staging/macosc/mozilla-central/nightly/mozconfig edited to remove the universal import at the top and this environment variable set:

   MOZ_OBJDIR=obj-firefox

The build was clean and I've downloaded and am now running the binary.

It needs to be looked at to make sure I haven't missed anything.

Comment 5

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #4)
> I've done a stock build with
> configs/mozilla2-staging/macosc/mozilla-central/nightly/mozconfig edited to
> remove the universal import at the top and this environment variable set:
> 
>    MOZ_OBJDIR=obj-firefox
> 
> The build was clean and I've downloaded and am now running the binary.
Bear: sweet! 


> It needs to be looked at to make sure I haven't missed anything.
Josh: can you try running this build on your machine, and inspect how its compiled, linked, etc? I'd like to verify that its all ok, before we start setting up a whole bunch of machines like this.

Comment 6

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #5)
> (In reply to comment #4)
> > I've done a stock build with
> > configs/mozilla2-staging/macosc/mozilla-central/nightly/mozconfig edited to
> > remove the universal import at the top and this environment variable set:
> > 
> >    MOZ_OBJDIR=obj-firefox
> > 
> > The build was clean and I've downloaded and am now running the binary.
> Bear: sweet! 

Bear, can you put that build someplace that Josh can see it? Maybe on people?

Comment 7

[Mike Taylor [:bear]]

(In reply to comment #6)

Not sure if I need to do anything else - but I've scp'd this to my people.mozilla.com working area

Minefield_10.6_x86_64.tar.bz2

Comment 8

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #7)
> (In reply to comment #6)
> 
> Not sure if I need to do anything else - but I've scp'd this to my
> people.mozilla.com working area
> 
> Minefield_10.6_x86_64.tar.bz2

josh asked offline, so to clarify, the full path is:

people.mozilla.com:/home/mtaylor/Minefield_10.6_x86_64.tar.bz2

Comment 9

[Josh Aas]

The build doesn't work on my machine. Not sure what is wrong. Maybe you pulled from mozilla-central at a bad time? Can you post the full mozconfig here?

Comment 10

[Mike Taylor [:bear]]

this is what I used:

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-firefox

ac_add_options --enable-application=browser
ac_add_options --enable-update-channel=nightly
ac_add_options --enable-update-packaging
ac_add_options --enable-tests
ac_add_options --enable-codesighs
ac_add_options --disable-install-strip

export CFLAGS="-gdwarf-2"
export CXXFLAGS="-gdwarf-2"

# For NSS symbols
export MOZ_DEBUG_SYMBOLS=1

# Needed to enable breakpad in application.ini
export MOZILLA_OFFICIAL=1

# Enable parallel compiling
mk_add_options MOZ_MAKE_FLAGS="-j4"

Comment 11

[Mike Taylor [:bear]]

(In reply to comment #9)
> The build doesn't work on my machine. Not sure what is wrong. Maybe you pulled
> from mozilla-central at a bad time? Can you post the full mozconfig here?

bah - turns out something borked when I did the tarball.  I was looking at it in Finder and realized the file size was too small.

Redid the compress using Finder and have uploaded a new file:

Minefield.zip

Comment 12

[Mike Taylor [:bear]]

(In reply to comment #9)
> The build doesn't work on my machine. Not sure what is wrong. Maybe you pulled
> from mozilla-central at a bad time? Can you post the full mozconfig here?

Josh - have you had a chance to try the Minefield.zip that I uploaded?

Comment 13

[Josh Aas]

Yup - build works. Thanks!

Comment 14

[Mike Taylor [:bear]]

Remaining items to be done:

 * ssh key environment
 * install 7zip (need to pull from existing 10.6 mini if possible)
 * verify zero-to-staging setup
 * move plists into place for buildbot startup
 * confirm .profile contents

I'm also filing a bug now to have IT reinstall stock 10.6 on the machine so that I can run thru the refimage wiki page steps and verify they are complete and accurate.

Comment 15

[Mike Taylor [:bear]]

Done:
 * Followed steps documented https://wiki.mozilla.org/ReferencePlatforms/Mac-10.6 on fresh OS X 10.6 install
 * Generated test build

TBD:
 * final plist and staging ssh setup
 * have someone review profile, buildbot and puppet config
 * add to staging-master to test

Comment 16

[Mike Taylor [:bear]]

Josh:

I've uploaded a test build done against mozilla-central from the 10.6 ref image, the file is at

http://people.mozilla.com:/home/mtaylor/Minefield_20100316_darwin10-ref.zip

Could you take a look at the app and let me know if you see any issues.  I've done a sanity check/run on my 10.6 laptop and it's running fine so far.

thanks

Comment 17

[Mike Taylor [:bear]]

Josh:

I have uploaded the i386 and x86_64 binaries generated by the mozconfig you emailed 

http://people.mozilla.com:/home/mtaylor/Minefield-20100319_darwin10-ref.zip

the mozconfig is attached but it needs to be tweaked because after building i386 and x86_64 it continues and tries to do a ppc build

thanks

Comment 18

[Mike Taylor [:bear]]

Attachment: mozconfig used to generate 20100319 build

Comment 19

[Mike Taylor [:bear]]

you think I could go a single day without any typos...

http://people.mozilla.com/home/mtaylor/Minefield_20100319_darwin10-ref.zip

Comment 20

[Josh Aas]

Builds seem to work just fine, thanks.

Comment 21

[Mike Taylor [:bear]]

the moz2-darwin10-ref server is ready to image.

after image is saved can you create 2 slaves so we can sanity check in our staging environment?

thanks

Comment 22

[Mike Taylor [:bear]]

Attachment: buildbot-tac.py update for darwin10 hostnames

Comment 23

[Mike Taylor [:bear]]

status of the 10.6 image:

- /tools/* directory is ready for puppet-ification
- cltbld environment finished
- buildbot slave test run done - no environment hitches noticed
- i386 and x86_64 binaries created and tested off machine

pending: 

- waiting for bug 411588 to land (fix to flight.mk) before declaring the build environment done
- waiting for IT to do a 2 slave image so we can do end-to-end testing and finish the rest of the releng environment tweaks required

Comment 24

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #23)
> status of the 10.6 image:
> 
> - /tools/* directory is ready for puppet-ification
> - cltbld environment finished
> - buildbot slave test run done - no environment hitches noticed
> - i386 and x86_64 binaries created and tested off machine
Very cool.

> pending: 
> - waiting for bug 411588 to land (fix to flight.mk) before declaring the build
> environment done
> - waiting for IT to do a 2 slave image so we can do end-to-end testing and
> finish the rest of the releng environment tweaks required
Imaging work being tracked in bug#548109

Comment 25

[[e-mail] (:bhearsum)]

I had a look around the ref platform and slave01. Here's what I found that needs work:
* moz2-darwin10-ref.build.mozilla.org needs to be added to Puppet's site-production.pp (http://hg.mozilla.org/build/puppet-manifests/file/tip/site-production.pp)
* The dirs in /tools needs to be versioned. The 10.5 ref platform page has instructions. Here's what one of them looks like on a 10.5 machine:
lrwxr-xr-x   1 root    admin       28 Oct 23 09:15 buildbot -> /tools/buildbot-5f43578cba2b
drwxr-xr-x  21 root    admin      714 Sep 24 06:07 buildbot-5f43578cba2b
* Since you're using a custom Python in /tools, please build zope in /tools, too.
* buildbot-tac script in /usr/local/bin needs to know about moz2-darwin10-ref
* buildbot doesn't launch, python error in /var/log/messages. probably because the plist is in LaunchDaemons rather than LaunchAgents
* buildbot-tac launching plist is missing; needs to go in LaunchAgents
* The ref platform should have staging keys on it, NOT production. You can get the staging keys from moz2-darwin9-slave03:~cltbld/.ssh
* puppet-manifests need some work. Not all of the Darwin {} blocks in them apply to 10.6. Need to protect the ones that are 10.5 only behind case $operatingsystemversion {} blocks.

And while not *pressing*, there's a few things that should be managed by Puppet:
* all of the /tools directories (requires modifications and checking operatingsystemversion here: http://hg.mozilla.org/build/puppet-manifests/file/tip/packages/devtools.pp)
* the puppet / buildbot / buildbot-tac launchers, which probably require some work in http://hg.mozilla.org/build/puppet-manifests/file/tip/os/osx.pp before they can be managed by Puppet.

Another note is that when filing IT bugs for getting slaves cloned, please be specific about the names. slave01 and 02 are called "moz2-darwinX-slaveNN", which breaks conditions in buildbot-tac.py, and is inconsistent with everything else. It's important to get this right the first time.

Comment 26

[Mike Taylor [:bear]]

(In reply to comment #25)
> I had a look around the ref platform and slave01. Here's what I found that
> needs work:
> * moz2-darwin10-ref.build.mozilla.org needs to be added to Puppet's
> site-production.pp
> (http://hg.mozilla.org/build/puppet-manifests/file/tip/site-production.pp)
> * The dirs in /tools needs to be versioned. The 10.5 ref platform page has
> instructions. Here's what one of them looks like on a 10.5 machine:
> lrwxr-xr-x   1 root    admin       28 Oct 23 09:15 buildbot ->
> /tools/buildbot-5f43578cba2b
> drwxr-xr-x  21 root    admin      714 Sep 24 06:07 buildbot-5f43578cba2b

The 10.5 ref image wiki page I was using doesn't even mention versioning so I wasn't aware of that requirement.

> * Since you're using a custom Python in /tools, please build zope in /tools,
> too.
> * buildbot-tac script in /usr/local/bin needs to know about moz2-darwin10-ref

Will fix them.

> * buildbot doesn't launch, python error in /var/log/messages. probably because
> the plist is in LaunchDaemons rather than LaunchAgents

ah - this was my bonehead miss - saw it in the 10.5 ref image and did not correct for how 10.6 does it.

> * buildbot-tac launching plist is missing; needs to go in LaunchAgents
> * The ref platform should have staging keys on it, NOT production. You can get
> the staging keys from moz2-darwin9-slave03:~cltbld/.ssh

odd - that's where I *thought* I pulled them from - will redo

> * puppet-manifests need some work. Not all of the Darwin {} blocks in them
> apply to 10.6. Need to protect the ones that are 10.5 only behind case
> $operatingsystemversion {} blocks.
> 
> And while not *pressing*, there's a few things that should be managed by
> Puppet:
> * all of the /tools directories (requires modifications and checking
> operatingsystemversion here:
> http://hg.mozilla.org/build/puppet-manifests/file/tip/packages/devtools.pp)
> * the puppet / buildbot / buildbot-tac launchers, which probably require some
> work in http://hg.mozilla.org/build/puppet-manifests/file/tip/os/osx.pp before
> they can be managed by Puppet.
> 
> Another note is that when filing IT bugs for getting slaves cloned, please be
> specific about the names. slave01 and 02 are called "moz2-darwinX-slaveNN",
> which breaks conditions in buildbot-tac.py, and is inconsistent with everything
> else. It's important to get this right the first time.

lesson learned.

Comment 27

[Mike Taylor [:bear]]

Attachment: add refimage hostname to IGNORE_HOSTS list

Comment 28

[Mike Taylor [:bear]]

ok, got the clue-stick applied in IRC.  

What I was missing was the project-version directory name for the installed tools - i.e. python-2.6.3, zope-3.5.3, ...

Comment 29

[[e-mail] (:bhearsum)]

Attachment: [wip] refactoring of puppet manifests for 10.6

work in progress patch of puppet-manifests updates for 10.6. The buildbot.tac generation stuff is shared by both of them; as is some of /tools. Some of the 10.5 specific things probably aren't 10.5 specific, but we can fix that later. For now, I just wanted to share the most essential things.

I've tested on 10.5 and confirmed that this changes nothing for that platform. Waiting for the 10.6 machines to be moved to the build network, then bear and I will test on 10.6.

Comment 30

[[e-mail] (:bhearsum)]

Comment on attachment 434281 [details] [diff] [review]
add refimage hostname to IGNORE_HOSTS list

Needs the full hostname there, moz2-darwin10-ref.build.mozilla.org

Comment 31

[Mike Taylor [:bear]]

Attachment: [WIP] changes to config.py to add macosx64 environment

Comment 32

[Mike Taylor [:bear]]

Attachment: add refimage hostname to IGNORE_HOSTS list

Comment 33

[[e-mail] (:bhearsum)]

Comment on attachment 434337 [details] [diff] [review]
[WIP] changes to config.py to add macosx64 environment

>diff --git a/mozilla2-staging/config.py b/mozilla2-staging/config.py
>+MAC_MINIS64 = ['moz2-darwin10-slave%02i' % x for x in range(1,3)]

I think we should name these after what they are, rather than what they build. MAC_SNOW_MINIS would be a better name.

>+MAC_MINIS   = ['moz2-darwin9-slave%02i' % x for x in range(1,69)]
>+XSERVES     = ['bm-xserve%02i' % x for x in [6,7,9,11,12,16,17,18,19,21,22]]
>+WIN32_VMS   = ['win32-slave%02i' % x for x in range(1,61)]
>+WIN32_IXS   = ['mw32-ix-slave%02i' % x for x in range(1,26)]
>+LINUX_VMS   = ['moz2-linux-slave%02i' % x for x in range(1,61)]
>+LINUX_IXS   = ['mv-moz2-linux-ix-slave%02i' % x for x in range(1,26)]
> SLAVES = {
>-    'linux': LINUX_VMS + LINUX_IXS,
>-    'linux64': ['moz2-linux64-slave%02i' % x for x in range(1,13)],
>-    'win32':  WIN32_VMS + WIN32_IXS,
>-    'macosx': MAC_MINIS + XSERVES,
>+    'linux':    LINUX_VMS + LINUX_IXS,
>+    'linux64':  ['moz2-linux64-slave%02i' % x for x in range(1,13)],
>+    'win32':    WIN32_VMS + WIN32_IXS,
>+    'macosx':   MAC_MINIS + XSERVES,
>+    'macosx64': MAC_MINIS64,

Same here, use macosx-snow, or something.

>+        'macosx64': {},
>         'linux-debug': {},
>         'linux64-debug': {},
>         'macosx-debug': {},
>+        'macosx64-debug': {},

However, it's correct to use '64' here, since this section actually sets up which builds will happen.


>+        'macosx64': {
>+            'base_name': 'OS X 10.6.2 %(branch)s',
>+            'mozconfig': 'macosx/%(branch)s/nightly',

you'll want macosx64 here.

>+            'upload_symbols': True,
>+            'download_symbols': True,

I'm sure if these will work yet, but let's try it.

>+            'slaves': SLAVES['macosx64'],
>+            'platform_objdir': "%s/x86_64" % OBJDIR,
>+            'update_platform': 'Darwin_Universal-gcc3',

This is going to have to be different in order to maintain separate update streams for ppc+i386 and x86_64. This will depend on some product repo changes too, I think.


You also need to override 'platforms' for 1.9.1, 1.9.2, and lorentz to explicitly not include these new build types. (I realize we may want to start shipping them in 1.9.2, but let's stabilize on trunk first.)

This is a good start, but needs some work.

Comment 34

[[e-mail] (:bhearsum)]

Attachment: puppet manifests factored for 10.6

A few things here:
* Protecting 10.5 specific stuff behind a case statement
* Addition of 10.6 specific things (profile file, some tools version differences)
* Indentation fixes

I've tested this in staging against both a 10.5 and 10.6 slave. No difference between this and the current puppet-manifests tip on the 10.5 slave. On the 10.6 slave, it executes correctly and syncs up /tools, Puppet launchers, buildbot launchers, and buildbot-tac launchers.

The only sortof sucky thing here is that all of the shared things live in 'darwin9' -- so the 10.6 slaves will pull some files from there. If that's a big deal, I can take the time to reorganize the manifests and files.

Comment 35

[Mike Taylor [:bear]]

Attachment: [WIP] changes to config.py to add macosx64 environment

I have a question about what to do with the other platforms to disable osx 64

The "enable*" bits I think just need to be set to False but what about "build_space"?  is that to be set to a value of 0?  heck, what is that value for?

Or do I just not include it in the 'platforms' list?  Since they are not, are the other dictionary entries for each version just there for completeness sake?

Comment 36

[Mike Taylor [:bear]]

Attachment: changes to config.py to add macosx64 environment

Comment 37

[[e-mail] (:bhearsum)]

Attachment: 10.6 puppet manifests, shared parts moved, comment updates

Catlee, I think this addresses your comments. I've updated the comment around config_version, moved things to a shared dir, and fixed a small bug with the Twisted installation (we check for a dir that only exists if the source was tar'ed up with the installed twisted).

Comment 38

[[e-mail] (:bhearsum)]

Comment on attachment 434591 [details] [diff] [review]
changes to config.py to add macosx64 environment

oops, set the wrong thing obsolete

Comment 39

[[e-mail] (:bhearsum)]

Comment on attachment 434591 [details] [diff] [review]
changes to config.py to add macosx64 environment

>+        'macosx64': {
>+            'base_name': 'OS X 10.6 %(branch)s',
>+            'mozconfig': 'macosx64/%(branch)s/nightly',
>+            'profiled_build': False,
>+            'builds_before_reboot': 5,
>+            'build_space': 8,
>+            'upload_symbols': True,
>+            'download_symbols': True,
>+            'slaves': SLAVES['macosx64'],
>+            'platform_objdir': "%s/x86_64" % OBJDIR,

Now that we've decided to do straight x86_64 builds now for now, this should just be OBJDIR -- we only have subdirs in universal builds.

The mozconfig in the macosx64-debug is still wrong.

You missed my comments about not turning this on for 1.9.1/1.9.2/lorentz, for now. You'll need something like:
BRANCHES['mozilla-1.9.1']['platforms'] = {
    'linux': {},
    'linux64': {},
    etc.
}

at the start of each of those sections.

Getting closer!

Comment 40

[Mike Taylor [:bear]]

Attachment: changes to config.py to add macosx64 environment

- added clearing of macosx64 and macosx64-debug from 1.9.1, 1.9.2 and lorentz sections
- fixed missed correction for objdir now that only a single platform is targetted

Comment 41

[[e-mail] (:bhearsum)]

Comment on attachment 434616 [details] [diff] [review]
10.6 puppet manifests, shared parts moved, comment updates

changeset:   115:0a59953ce8de


Also landed the reorganization in puppet-files.

Comment 42

[[e-mail] (:bhearsum)]

Comment on attachment 434692 [details] [diff] [review]
changes to config.py to add macosx64 environment

This looks fine. However, we've still not settled on hostnames according to bug 548109, so we may have to change this....we'll wait and see.

Comment 43

[[e-mail] (:bhearsum)]

Comment on attachment 433626 [details] [diff] [review]
buildbot-tac.py update for darwin10 hostnames

changeset:   550:19cc77f922de

Comment 44

[[e-mail] (:bhearsum)]

Comment on attachment 434341 [details] [diff]
add refimage hostname to IGNORE_HOSTS list

Checking in buildbot-tac;
/mofo/puppet-files/shared/buildbot-tac,v  <--  buildbot-tac
new revision: 1.16; previous revision: 1.15
done

Comment 45

[Mike Taylor [:bear]]

Attachment: buildbot-configs changes for macosx64

1 of 2

Comment 46

[Mike Taylor [:bear]]

Attachment: buildbotcustom changes for macosx64

2 of 2

Comment 47

[[e-mail] (:bhearsum)]

Comment on attachment 435076 [details] [diff] [review]
buildbot-configs changes for macosx64

I was chatting with Catlee a bit about this patch, and one thing he recommended was to do the exceptions for 1.9.1/1.9.2/lorentz elsewhere. Specifically, it looks like you can do it right before the platform defaults are copied in. Eg:
BRANCHES = {
  'mozilla-1.9.1': {'platforms': {'linux', 'linux64', ... },
  ...
}

Sorry to ask you to change this again, but it's probably best to keep it all in one place.

After that, let's get this landed and follow up with more patches if needed.

Comment 48

[[e-mail] (:bhearsum)]

Comment on attachment 435077 [details] [diff] [review]
buildbotcustom changes for macosx64

There's a few more places in buildbotcustom that need updating. I found one in steps/test.py -- can you grep around and look for more? Some aren't caught until runtime :-(.

Comment 49

[Mike Taylor [:bear]]

Attachment: buildbot-configs changes for macosx64

Comment 50

[[e-mail] (:bhearsum)]

Comment on attachment 435199 [details] [diff] [review]
buildbot-configs changes for macosx64

Almost, but not quite. mozilla-central gets to inherit the defaults, so there's no reason to set it explicitly

Comment 51

[Mike Taylor [:bear]]

Attachment: buildbot-configs changes for macosx64

Comment 52

[Mike Taylor [:bear]]

Attachment: buildbot-configs changes for macosx64

prior patch had some local-only debug items included - fixed

Comment 53

[[e-mail] (:bhearsum)]

Comment on attachment 435204 [details] [diff] [review]
buildbot-configs changes for macosx64

Looks good to me. I'm going to adjust the MAC_SNOW_MINIS to be range(1,51) upon landing, though. I'll get this landed right away.

Comment 54

[Mike Taylor [:bear]]

Attachment: buildbotcustom changes for macosx64

- went thru and found all macosx references that were in a list
 - went thru and found all linux64 references that also had macosx references
 - went thru and found all platform == 'macosx' and converted to platform.startswith('macosx')

Comment 55

[[e-mail] (:bhearsum)]

Comment on attachment 435204 [details] [diff] [review]
buildbot-configs changes for macosx64

changeset:   2214:ce8e5cc4a1fe

Comment 56

[[e-mail] (:bhearsum)]

Comment on attachment 435205 [details] [diff] [review]
buildbotcustom changes for macosx64

changeset:   674:e08085930b8e

Comment 57

[[e-mail] (:bhearsum)]

Attachment: use separate buildbot launchers for 10.5 and 10.6

...which is necessary because we need to set a different PYTHONPATH in them.

The diff of launchers between darwin9 and darwin10 looks like this:
@@ -11,7 +11,7 @@
                 <key>PYTHONHOME</key>
                 <string>/tools/python</string>
                 <key>PYTHONPATH</key>
-                <string>/tools/buildbot/lib/python2.5/site-packages:/tools/twisted/lib/python2.5/site-packages/:/tools/twisted-core/lib/python2.5/site-packages:/tools/zope-interface/lib/python2.5/site-packages</string>
+                <string>/tools/buildbot/lib/python2.6/site-packages:/tools/twisted/lib/python2.6/site-packages/:/tools/twisted-core/lib/python2.6/site-packages:/tools/zope-interface/lib/python2.6/site-packages</string>
         </dict>
         <key>Label</key>
         <string>buildbot.start.slave</string>


I can post the full files if you'd like.

Comment 58

[[e-mail] (:bhearsum)]

Comment on attachment 435256 [details] [diff] [review]
use separate buildbot launchers for 10.5 and 10.6

Landed:
Removing darwin-shared/buildbot.start.slave.plist;
/mofo/puppet-files/darwin-shared/buildbot.start.slave.plist,v  <--  buildbot.start.slave.plist
new revision: delete; previous revision: 1.1
done
RCS file: /mofo/puppet-files/darwin10/buildbot.start.slave.plist,v
done
Checking in darwin10/buildbot.start.slave.plist;
/mofo/puppet-files/darwin10/buildbot.start.slave.plist,v  <--  buildbot.start.slave.plist
initial revision: 1.1
done
Checking in darwin9/buildbot.start.slave.plist;
/mofo/puppet-files/darwin9/buildbot.start.slave.plist,v  <--  buildbot.start.slave.plist
new revision: 1.3; previous revision: 1.2
done

changeset:   119:80c994db2761

Comment 59

[Mike Taylor [:bear]]

marking as complete:

- moz2-darwin10-slave01 has generated a 64bit DMG
- the build cycle completed (albeit with a couple failures but not image related)
- Josh has looked at the package and gave it a sanity-check +1