545576 - Add "greaterthaneq" and "lessthaneq" charts to do >= and <= searches

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Max Kanat-Alexander]

In order to move the "votes" functionality into an extension without hooking Search.pm (which we are currently pretty much unable to do in any good way), I need a "greaterthaneq" chart in Search.pm.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1 (untested)

Two for the price of one.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 426433 [details] [diff] [review]
patch - v1 (untested)

A few of the other charts need modification, and we should add these to the boolean-charts template.

Comment 4

[Reed Loden [:reed]]

Attachment: patch - v2 (untested)

Comment 5

[Max Kanat-Alexander]

Comment on attachment 426437 [details] [diff] [review]
patch - v2 (untested)

Looks good to me! :-) Thanks! :-)

Comment 6

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                                                                    
modified Bugzilla/Search.pm
modified template/en/default/search/boolean-charts.html.tmpl
Committed revision 6985.

Comment 7

[Frédéric Buclin]

Well, the way of doing is rather "stupid". This is the exact same patch as Rosie's one, with the removal of the license part. Hard to assume you never looked at her patch. Weird and unfair way to work around licensing issues.

Comment 8

[Reed Loden [:reed]]

(In reply to comment #7)
> Well, the way of doing is rather "stupid". This is the exact same patch as
> Rosie's one, with the removal of the license part. Hard to assume you never
> looked at her patch. Weird and unfair way to work around licensing issues.

I didn't even know the other bug or patch existed when I wrote the first version, and v2 was based on quick comments from IRC (from me asking about the other charts and mkanat mentioning that I should add it to boolean-charts.html.tmpl), not from anything in the other bug. So, therefore, it's original work and not based on anything derivative from the other bug.

Comment 9

[Max Kanat-Alexander]

The implementation is obvious and straightforward, it's totally unsurprising that two people would develop identical patches.

Comment 10

[Max Kanat-Alexander]

Added to the release notes in bug 604256.