545581 - Make AreAncestorViewsVisible stop at chrome/content boundary

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

AreAncestorViewsVisible in nsFrame.cpp checks up the view chain looking for a hidden view and returns true if there is one. This is used in nsFrame::IsFocusable to ensure that content in hidden popups and deck panels isn't focusable. However, it breaks with the patches in bug 130078 because it finds that the view containing the toplevel content document for a hidden tab is hidden, and so content in a hidden tab is treated as non-focusable, which we don't want.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This patch makes us explicitly stop at a content/chrome boundary. This makes sense to me because the behaviour of content shouldn't depend on the state of the chrome.

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 426444 [details] [diff] [review]
fix

Add a test that fails with the patches in bug 130078 without this patch, unless we already have one...
r=mats

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

focus mochitests fail with bug 130078 without this patch.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/d94b2e28cd61