Closed Bug 545593 Opened 14 years ago Closed 14 years ago

Remove nsViewManager::Enable/DisableRefresh.

Categories

(Core :: Web Painting, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file, 1 obsolete file)

Remove nsViewManager::Enable/DisableRefresh so that we can have chrome and content in one viewmanager hierarchy.
Attached patch patch (obsolete) — Splinter Review
Attachment #426457 - Flags: review?(roc)
There need to be some IID revs in there, right?

I love that code going away!
Yes, of course, thanks for reminding me. New patch coming up.
Attached patch patch v2Splinter Review
Rev the IIDs.
Attachment #426457 - Attachment is obsolete: true
Attachment #426462 - Flags: review?(roc)
Attachment #426457 - Flags: review?(roc)
Landed
http://hg.mozilla.org/mozilla-central/rev/93c7b23284b8

but backed out for causing some failures in browser_bug415846.js only on debug tests.
http://hg.mozilla.org/mozilla-central/rev/38929916c6d1
http://hg.mozilla.org/mozilla-central/rev/4e883e25a86c

Luckily I can reproduce on my machine, so I'll debug it.
I now think that the failure was likely unfiled random orange as there were two pushes after mine before I backed out and both were green. I filed bug 546169 on this. I thought I could reproduce but it turns out that test will almost always fail when run alone even in a clean build because the safebrowsing service doesn't get initialized until 2 seconds after load.

So I will land this again when the tree opens.
http://hg.mozilla.org/mozilla-central/rev/5b74da35092c
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: