545593 - Remove nsViewManager::Enable/DisableRefresh.

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Timothy Nikkel (:tnikkel)]

Remove nsViewManager::Enable/DisableRefresh so that we can have chrome and content in one viewmanager hierarchy.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

There need to be some IID revs in there, right?

I love that code going away!

Comment 3

[Timothy Nikkel (:tnikkel)]

Yes, of course, thanks for reminding me. New patch coming up.

Comment 4

[Timothy Nikkel (:tnikkel)]

Attachment: patch v2

Rev the IIDs.

Comment 5

[Timothy Nikkel (:tnikkel)]

Landed
http://hg.mozilla.org/mozilla-central/rev/93c7b23284b8

but backed out for causing some failures in browser_bug415846.js only on debug tests.
http://hg.mozilla.org/mozilla-central/rev/38929916c6d1
http://hg.mozilla.org/mozilla-central/rev/4e883e25a86c

Luckily I can reproduce on my machine, so I'll debug it.

Comment 6

[Timothy Nikkel (:tnikkel)]

I now think that the failure was likely unfiled random orange as there were two pushes after mine before I backed out and both were green. I filed bug 546169 on this. I thought I could reproduce but it turns out that test will almost always fail when run alone even in a clean build because the safebrowsing service doesn't get initialized until 2 seconds after load.

So I will land this again when the tree opens.

Comment 7

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/5b74da35092c