Closed
Bug 54566
Opened 26 years ago
Closed 25 years ago
Software error generated when adding invalid dependencies
Categories
(Bugzilla :: Bugzilla-General, defect, P3)
Bugzilla
Bugzilla-General
Tracking
()
VERIFIED
FIXED
Bugzilla 2.12
People
(Reporter: mozilla, Assigned: Chris.Yeh)
References
Details
(Whiteboard: 2.14)
Attachments
(1 file)
|
484 bytes,
patch
|
Details | Diff | Splinter Review |
If you try to make a bug depend on or block an invalid bug id, bugzilla
correctly reports in big bad red and black that the bug id you entered
was invalid. However, it then generates a software error. I changed
the die() to a confess() and got this stack trace:
SELECT profiles.userid, profiles.groupset, profiles.login_name,
profiles.login_name = 'aspiers@guideguide.com' AND profiles.cryptpassword =
logincookies.cryptpassword AND logincookies.hostname = '192.168.1.1',
profiles.disabledtext FROM profiles, logincookies WHERE logincookies.cookie =
'310' AND profiles.userid = logincookies.userid: Table 'logincookies' was not
locked with LOCK TABLES at globals.pl line 140
main::SendSQL('SELECT profiles.userid, profiles.groupset,
profiles.login_name, ...') called at CGI.pl line 538
main::quietly_check_login() called at CGI.pl line 909
main::GetCommandMenu() called at globals.pl line 944
main::Param('commandmenu') called at globals.pl line 977
main::PerformSubsts('<TABLE BORDER="0"><TR><TD
BGCOLOR="#000000" VALIGN="TOP">^J<TABLE...') called at
CGI.pl line 812
main::PutFooter() called at CGI.pl line 821
main::PuntTryAgain('12345 is not a legal bug number') called at
/nfs-home/stuff/web/bugzilla/process_bug.cgi line 727
Why MySQL was expecting logincookies to be locked, I have no idea ...
Updated•25 years ago
|
Whiteboard: 2.14
Comment 2•25 years ago
|
||
ping cyeh...
Is this the same thing you just fixed in editusers.cgi? Same problem perhaps?
It appears to be a similar problem: we lock the tables to begin bug processing
but when an error occurs we punt without unlocking the tables first.
We're going to have to walk through all the logic of process_bug.cgi and see
where we should be unlocking the tables in a failure case.
checked patch into trunk
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 7•25 years ago
|
||
In search of accurate queries.... (sorry for the spam)
Target Milestone: --- → Bugzilla 2.12
Comment 9•25 years ago
|
||
Moving closed bugs to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: other → unspecified
Updated•13 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•