545744 - Increase limit of users on etherpad

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations: Projects, task)

Description

[Chris AtLee [:catlee]]

Apparently there's a limit to the number of concurrent users on etherpad.  If you go above the limit, visitors get a page explaining that we're so cheap we can't afford the paid version of etherpad.

Please dial the number of users knob all the way to 11.  Or higher (like 1000), if they make knobs that go that high.

Comment 1

[matthew zeier [:mrz]]

I wonder if this is even possible with the non-paid version.

Comment 2

[Chris AtLee [:catlee]]

Don't we have the source?

Comment 3

[Johnathan Nightingale [:johnath]]

If it's not a config-time thing, we can probably patch it (OSS FTW!) and then file the bug upstream.  :)

Comment 4

[Johnathan Nightingale [:johnath]]

The check appears to be here:

http://code.google.com/p/etherpad/source/browse/trunk/etherpad/src/etherpad/quotas.js#24

which returns either 1e6 or 1e9 depending on what isPNE() returns - but that's only when isProDomainRequest() returns true.

So we need to convince it that we are...

That function is defined over here:

http://code.google.com/p/etherpad/source/browse/trunk/etherpad/src/etherpad/pro/pro_utils.js#56

which gets the value out of the appjet cache.  I don't know me anything about appjet caches, but I bet commenting out the body of that function and replacing it with:

return true

would bring us some immediate joy, here - however hacky.

Comment 5

[Johnathan Nightingale [:johnath]]

(also - looking at http://code.google.com/p/etherpad/source/browse/trunk/etherpad/src/etherpad/quotas.js#33 in more detail - pads with "conf-" as a prefix get 64 users instead of 16 - we shouldn't do the first thing I suggested - might have surprising side effects - we should just change those magic numbers - and then maybe write a patch for upstream that turns it into a config variable.)

Comment 6

[Johnathan Nightingale [:johnath]]

Attachment: Hacked quotas.js

What do you think? I know hacking stuff we take from an upstream source is odd, but this should do the trick, right?

Comment 7

[matthew zeier [:mrz]]

Your attachment looks just like the original file.  

Here's what I did:

  } else {
    // etherpad.com public pads
    if (globalPadId && stringutils.startsWith(globalPadId, "conf-")) {
      return 64;
    } else {
      return 128;
//      return 16;

Comment 8

[:Gavin Sharp [email: [e-mail]]]

The original file has "/* Hacked for etherpad.mozilla.com */" in it? :)

The attachment has most of the original file commented out.

Comment 9

[matthew zeier [:mrz]]

I diff'd the attachement with what's already on the server.  So either someone beat me to it and didn't own up to it or nothing changed. 

I'll pretend this is fixed then?

Comment 10

[Johnathan Nightingale [:johnath]]

Comment on attachment 426692 [details] [diff] [review]
Hacked quotas.js

Clearing stale review request.