545798 - buildbot.tac gets wrong password and hostname for xserves

Status: RESOLVED WORKSFORME

(Release Engineering :: General, defect, P5)

Description

[Nick Thomas [:nthomas] (UTC+12)]

In setting up bm-xserve21 again (bug 545560), we got 
  passwd = 'unknown'
in buildbot.tac.

I think the error is in /usr/local/bin/buildbot-tac:
PASSWORD="unknown"
# Slave-type specific overrides
if `echo ${HOSTNAME} | grep -q moz2`; then
    PASSWORD=${BUILDSLAVE_PASSWORD}

Not clear to me what platforms this runs on, but the talos block doesn't know about the rev3 machines either. Does this file live in a VCS somewhere or just in puppet-files/shared ?

Comment 1

[[e-mail] (:bhearsum)]

It's only intended for Mac and Linux -- we have a batch file on Windows. puppet-files/shared is its home, which is actually a CVS mananged directory.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

On bm-xserve06 I also noticed it set the slave name to the FQDN instead of just 'bm-xserve06'.

Comment 3

[Chris Cooper [:coop] (he/him)]

These seem to be fine now.