546003 - Closing Calendar or Task tab throws "An error occurred updating the ... command"

Status: RESOLVED WORKSFORME

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning 1.0b2pre (20100212) with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.2pre) Gecko/20100213 Lanikai/3.1b1pre.

Steps to reproduce:
1. Install Lightning 1.0b2pre into Lanikai 3.1b1pre
2. Open Calendar or Task tab
3. Close the tab and check Error Console

Actual results: 
Error Console shows about 30 entries like the following one. Each entry reports a different command, e.g. calendar_publish_calendar_command, cmd_undo, cmd_deleteJunk:

Error: An error occurred updating the calendar_new_calendar_command command: [Exception... "'[JavaScript Error: "too much recursion" {file: "chrome://messenger/content/tabmail.xml" line: 1026}]' when calling method: [nsIController::isCommandEnabled]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 80"  data: yes]
Source File: chrome://global/content/globalOverlay.js
Line: 86

The errors are not reported if closing a mail tab.

Comment 1

[Nomis101]

For similar Bugs see Bug 535758 and Bug 476709

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

The error is different now, but we really need to get rid of this:

Error: An error occurred updating the calendar_new_calendar_command command:
[Exception... "'[JavaScript Error: "too much recursion" {file:
"chrome://messenger/content/tabmail.xml" line: 1026}]' when calling method:
[nsIController::isCommandEnabled]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 80"  data:
yes]
Source File: chrome://global/content/globalOverlay.js
Line: 86


I suspect this happens because we are calling stuff from our global command
handler, which in turn might call the thunderbird handler, which in turn calls
the handler for the currently selected tab (our handler).

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Will be fixed by bug 527254

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Seems to work now, closing