Closed Bug 546009 Opened 11 years ago Closed 11 years ago

Want plugin filename in crash lists (optionally?)

Categories

(Socorro :: General, task)

x86
macOS
task
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: benjamin, Assigned: ozten)

Details

Attachments

(1 file)

By "not super-high priority" I mean it doesn't block anything at all.
Target Milestone: --- → 1.6
Assignee: nobody → ozten.bugs
(In reply to comment #0)
This link is for process=All, which currently will match all crashes (including oopp), but won't join results against the plugins crash reports table.

To show plugin metadata be sure to search for process=plugin. This will match only oopp crashes and we will join against the plugins crash reports table.
This patch enhances our plugin info on query/query.

If either plugin name or version are set, then we show a column with both pieces of information.

If plugin filename is set, then we show a column with filename.

Testing Note: Search with Process=Plugin. Almost all plugin crashes (in dm-breakpad-stagedb) have only a filename... name and version are empty.
Attachment #433831 - Flags: review?(ryan)
Attachment #433831 - Flags: feedback?(laura)
Comment on attachment 433831 [details] [diff] [review]
First attempt to enhance plugin info on query/query

Looks good.  Just make sure to remove the debugging output atop the query page.  

http://skitch.com/ryansnyder/n5fs5/query-results-mozilla-crash-reports
Attachment #433831 - Flags: review?(ryan) → review+
Sending        webapp-php/application/controllers/query.php
Sending        webapp-php/application/models/common.php
Sending        webapp-php/application/views/common/list_by_signature.php
Transmitting file data ...
Committed revision 1874.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #433831 - Flags: feedback?(laura) → feedback+
Yes, although the data is obviously incorrect the feature does appear to be working.
Thx; yeah, a ton of data/datatypes aren't available on staging.  Maybe we need a new dump.

Verified, regardless.
Status: RESOLVED → VERIFIED
(In reply to comment #7)
To test, select "Plugins Only".

We should drill down on "data incorrect". Stage is mostly good data, a sample of prod data.

I looked at http://crash-stats.stage.mozilla.com/dumps/8e078615-33f8-4f39-9ccb-233002100329.jsonz
and see
"pluginVersion": ""
"processType": "plugin", 
"pluginFilename": "npwinext.dll", 
"pluginName": ""

Just confirming that we know that these fields are empty in real crashes and that is why the data is incorrect. If gecko *is supplying* these fields and they aren't making it into the jsonz file, then this is an unknown bug.
I first just did a search for "Firefox/All/Windows/1.9.3" and there were no reports in the past 2 weeks. When I added some other branches I got that one report with npwinext.dll
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.