546009 - Want plugin filename in crash lists (optionally?)

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Benjamin Smedberg]

For certain sorts of triage, it would be really helpful if the plugin filename were in crash lists,

e.g. http://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox%3A3.7a2pre&query_search=signature&query_type=exact&query=%400x0%20|%20mozilla%3A%3Aplugins%3A%3APPluginInstanceChild%3A%3AOnCallReceived%28IPC%3A%3AMessage%20const%26%2C%20IPC%3A%3AMessage*%26%29&date=&range_value=1&range_unit=weeks&process_type=all&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&signature=%400x0%20|%20mozilla%3A%3Aplugins%3A%3APPluginInstanceChild%3A%3AOnCallReceived%28IPC%3A%3AMessage%20const%26%2C%20IPC%3A%3AMessage*%26%29

This is not a super-high priority, and I understand that many people won't want to see this column at all, so I wonder if there's a way to make it optional or have a column selector?

Comment 1

[Benjamin Smedberg]

By "not super-high priority" I mean it doesn't block anything at all.

Comment 2

[Austin King [:ozten]]

(In reply to comment #0)
This link is for process=All, which currently will match all crashes (including oopp), but won't join results against the plugins crash reports table.

To show plugin metadata be sure to search for process=plugin. This will match only oopp crashes and we will join against the plugins crash reports table.

Comment 3

[Austin King [:ozten]]

Attachment: First attempt to enhance plugin info on query/query

This patch enhances our plugin info on query/query.

If either plugin name or version are set, then we show a column with both pieces of information.

If plugin filename is set, then we show a column with filename.

Testing Note: Search with Process=Plugin. Almost all plugin crashes (in dm-breakpad-stagedb) have only a filename... name and version are empty.

Comment 4

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Comment on attachment 433831 [details] [diff] [review]
First attempt to enhance plugin info on query/query

Looks good.  Just make sure to remove the debugging output atop the query page.  

http://skitch.com/ryansnyder/n5fs5/query-results-mozilla-crash-reports

Comment 5

[Austin King [:ozten]]

Sending        webapp-php/application/controllers/query.php
Sending        webapp-php/application/models/common.php
Sending        webapp-php/application/views/common/list_by_signature.php
Transmitting file data ...
Committed revision 1874.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Benjamin, do you see this working on http://crash-stats.stage.mozilla.com/products/Firefox?  Mind verifying?

Comment 7

[Benjamin Smedberg]

Yes, although the data is obviously incorrect the feature does appear to be working.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx; yeah, a ton of data/datatypes aren't available on staging.  Maybe we need a new dump.

Verified, regardless.

Comment 9

[Austin King [:ozten]]

(In reply to comment #7)
To test, select "Plugins Only".

We should drill down on "data incorrect". Stage is mostly good data, a sample of prod data.

I looked at http://crash-stats.stage.mozilla.com/dumps/8e078615-33f8-4f39-9ccb-233002100329.jsonz
and see
"pluginVersion": ""
"processType": "plugin", 
"pluginFilename": "npwinext.dll", 
"pluginName": ""

Just confirming that we know that these fields are empty in real crashes and that is why the data is incorrect. If gecko *is supplying* these fields and they aren't making it into the jsonz file, then this is an unknown bug.

Comment 10

[Benjamin Smedberg]

I first just did a search for "Firefox/All/Windows/1.9.3" and there were no reports in the past 2 weeks. When I added some other branches I got that one report with npwinext.dll