Port Bug 410996 - Answering a news article in a saved search folder not stored under a news account creates mail reply instead of follow-up

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
MailNews: Composition
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

({fixed-seamonkey2.0.4})

Trunk
seamonkey2.1a1
fixed-seamonkey2.0.4
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

953 bytes, patch
Karsten Düsterloh
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Created attachment 426853 [details] [diff] [review]
patch

From TB Bug 410996:
"When a news article is displayed within a search folder and the user hits
Ctrl-R to write a follow-up, a mail reply to the author of the article is
initiated instead."

We support gFolderDisplay.selectedMessageIsNews since Bug 517238 and I assume it's here to stay so I hope that's not an issue.
Attachment #426853 - Flags: review?(mnyromyr)

Comment 1

8 years ago
Comment on attachment 426853 [details] [diff] [review]
patch

With your patch, hitting ^R results in

Error: An error occurred executing the cmd_reply command: ReferenceError: event is not defined
Source File: chrome://global/content/globalOverlay.js
Line: 100

Clicking the reply button says

JavaScript error: chrome://messenger/content/mailWindowOverlay.js, line 1132: event is not defined


Also, can you try not to open composition at all if the message displayed comes from a RSS feed?
Attachment #426853 - Flags: review?(mnyromyr) → review-
(Assignee)

Comment 2

8 years ago
Created attachment 427157 [details] [diff] [review]
patch v2 [Checkin: Comment 8]

(In reply to comment #1)
> (From update of attachment 426853 [details] [diff] [review])
> With your patch, hitting ^R results in (...)

Bah, copy+paste. :-(

> Also, can you try not to open composition at all if the message displayed comes
> from a RSS feed?

Like so?
Attachment #426853 - Attachment is obsolete: true
Attachment #427157 - Flags: review?(mnyromyr)

Updated

8 years ago
Attachment #427157 - Flags: review?(mnyromyr) → review+

Comment 3

8 years ago
Comment on attachment 427157 [details] [diff] [review]
patch v2 [Checkin: Comment 8]

Yeah, much better.

OTOH, if you have a feed posting in the results, the Reply (All) buttons and (even context) menu items are still enabled. But I see this is the case for raw feed folders as well -> filed bug 546770.
(Assignee)

Comment 4

8 years ago
Comment on attachment 427157 [details] [diff] [review]
patch v2 [Checkin: Comment 8]

The corresponding TB bug (see initial comment) was fixed for TB 3.0.x as well so I'm requesting branch approval for parity (note that our fix does slightly more).
Attachment #427157 - Flags: superreview?(neil)
Attachment #427157 - Flags: approval-seamonkey2.0.4?

Comment 5

8 years ago
What happens if you have multiple messages selected?
(Assignee)

Comment 6

8 years ago
(In reply to comment #5)
> What happens if you have multiple messages selected?

Then the decision is made based on the first selected message (folderDisplay.js: this.selectedMessage -> gDBView.hdrForFirstSelectedMessage).

Comment 7

7 years ago
Comment on attachment 427157 [details] [diff] [review]
patch v2 [Checkin: Comment 8]

Well I guess this at least fixes the more common case of a search folder that searches a different account type (as distinct from a search folder that spans multiple account types).
Attachment #427157 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 8

7 years ago
Comment on attachment 427157 [details] [diff] [review]
patch v2 [Checkin: Comment 8]

http://hg.mozilla.org/comm-central/rev/76cbea62986a
Attachment #427157 - Attachment description: patch v2 → patch v2 [Checkin: Comment 8]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
Depends on: 410996
Depends on: 549802

Updated

7 years ago
Attachment #427157 - Flags: approval-seamonkey2.0.4? → approval-seamonkey2.0.4+

Comment 9

7 years ago
Comment on attachment 427157 [details] [diff] [review]
patch v2 [Checkin: Comment 8]

a=me for on SM2.04
(Assignee)

Comment 10

7 years ago
http://hg.mozilla.org/releases/comm-1.9.1/rev/c90248ec9911
Keywords: fixed-seamonkey2.0.4
You need to log in before you can comment on or make changes to this bug.