546090 - Tab drop indicator no longer disappears after a drop

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[[e-mail]]

Possibly as a result of the drag-n-drop changes (Enn can you confirm or deny?) we no longer get a drag exit when something gets dropped on the tabstrip.

Comment 1

[Neil Deakin]

That's correct. dragexit doesn't and shouldn't fire when a drop occurs, although that dragexit was firing was itself a regression behaviour that was only added when I implemented the new api.

Comment 2

[BlueAppleSlushie]

Attachment: Patch to hide drop indicator after drop

Since the ondragexit handler is no longer called after a drop is completed, the code to hide the drop indicator needed to be copied to the ondragdrop handler.

Comment 3

[[e-mail]]

Comment on attachment 432109 [details] [diff] [review]
Patch to hide drop indicator after drop

Thanks for looking into this! Some notes:
1. You don't actually set review+ yourself. You set review? with someone suitable from the peer list, and then they set review+ (or maybe review-).

>-                  ondragexit="nsDragAndDrop.dragExit(event, this.parentNode.parentNode); event.stopPropagation();">
>+                  ondragleave="nsDragAndDrop.dragExit(event, this.parentNode.parentNode); event.stopPropagation();">
2. What's the difference between ondragexit and ondragleave? (Perhaps there's a web page that describes this.)

>       <method name="onDrop">
>         <parameter name="aEvent"/>
>         <parameter name="aXferData"/>
>         <parameter name="aDragSession"/>
>         <body>
>           <![CDATA[
>             var newIndex = this.getDropIndex(aEvent);
>             var tabIndex;
3. I would have thought that hiding the indicator would be the first thing to do.

>+			document.getAnonymousElementByAttribute(this, "class",
4. Somehow the spaces on this line got changed into tabs, which is wrong.

Comment 4

[[e-mail]]

(In reply to comment #3)
>>-                  ondragexit="nsDragAndDrop.dragExit(event, this.parentNode.parentNode); event.stopPropagation();">
>>+                  ondragleave="nsDragAndDrop.dragExit(event, this.parentNode.parentNode); event.stopPropagation();">
>2. What's the difference between ondragexit and ondragleave? (Perhaps there's a
>web page that describes this.)
I looked this up, and I don't think I want this change until we stop using nsDragAndDrop.

Comment 5

[BlueAppleSlushie]

(In reply to comment #3)
> 1. You don't actually set review+ yourself. You set review? with someone
> suitable from the peer list, and then they set review+ (or maybe review-).
ok

> 3. I would have thought that hiding the indicator would be the first thing to
> do.
Fixed.  I know I can declare variables anywhere and yet...

> >+			document.getAnonymousElementByAttribute(this, "class",
> 4. Somehow the spaces on this line got changed into tabs, which is wrong.
Fixed.  Probably.

> >2. What's the difference between ondragexit and ondragleave? (Perhaps there's a
> >web page that describes this.)
> I looked this up, and I don't think I want this change until we stop using
> nsDragAndDrop.
Reverted to ondragexit.  nsDragAndDrop seemed to not mind the change from ondragexit to ondragleave but when I changed ondragdrop to ondrop I got some strange behaviour (repositioned tabs reloaded everytime!)

Comment 6

[BlueAppleSlushie]

Attachment: Patch to hide drop indicator after drop (2)

Comment 7

[[e-mail]]

Comment on attachment 432121 [details] [diff] [review]
 Patch to hide drop indicator after drop (2)

>+                    .collapsed = true;													
Not having much luck with tabs, are you ;-)

Comment 8

[[e-mail]]

Whomever checks in the patch, please remove the tabs, thanks.

Comment 9

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/b8d59c7adc0c - trailing tabs removed.