Created attachment 426894 [details] [diff] [review] Patch Until bug 525998 is actually addressed, all currently released branches should force disabling the svg output option.
Created attachment 426895 [details] [diff] [review] Patch Hum... without unrelated changes this time
Comment on attachment 426895 [details] [diff] [review] Patch Please wait for review(s) to be completed before requesting branch approval.
Comment on attachment 426895 [details] [diff] [review] Patch Looks good, thanks.
Let's get this in on mozilla-central.
Flags have completely changed, what is the one for approval on branches, now ?
"approval220.127.116.11" for Firefox 3.6.2 and "approval18.104.22.168" for Firefox 3.5.9 on https://bugzilla.mozilla.org/attachment.cgi?id=426895&action=edit, I guess. See https://wiki.mozilla.org/Releases/Flags on the various multi-state flags.
Comment on attachment 426895 [details] [diff] [review] Patch D'oh, I was looking for these flags at the wrong place...
Looks safe enough to approve, but how does adding postscript flags turn off SVG output?
Because it's unfortunately how this thing works. There is not even a flag for SVG, so you can't support, e.g. ps and svg but not pdf... See http://git.gnome.org/browse/gtk+/tree/modules/printbackends/file/gtkprintbackendfile.c#n594
That's even how the flags are documented: "If neither GTK_PRINT_CAPABILITY_GENERATE_PDF nor GTK_PRINT_CAPABILITY_GENERATE_PS is specified, GTK+ assumes that all formats are supported." Currently Mozilla only supports PDF and PS so it makes sense to explicitly specify these. http://hg.mozilla.org/mozilla-central/annotate/ab74c935e321/widget/src/gtk2/nsDeviceContextSpecG.cpp#l478
Comment on attachment 426895 [details] [diff] [review] Patch Approved for 22.214.171.124 and 126.96.36.199, a=dveditz for release-drivers
As given by Karl on IRC the problem here were the missing flags. If no flags are set, the dialog simply offers all possible output formats. Verified fixed on 1.9.2 with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:188.8.131.52) Gecko/20100316 Firefox/3.6.2 Also works on trunk with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a4pre) Gecko/20100322 Minefield/3.7a4pre