Closed Bug 546093 Opened 13 years ago Closed 13 years ago

Print dialog should not display the SVG output option when printing to a file

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a2
Tracking Flags:
Tracking Status
status1.9.2 --- .2-fixed
status1.9.1 --- .9-fixed

People

(Reporter: glandium, Assigned: glandium)

Details

(Keywords: verified1.9.2)

Attachments

(1 file, 1 obsolete file)

Patch
630 bytes, patch
karlt
: review+
dveditz
: approval1.9.2.2+
dveditz
: approval1.9.1.9+
Details | Diff | Splinter Review
Attached patch Patch (obsolete) — — Splinter Review 
Until bug 525998 is actually addressed, all currently released branches should force disabling the svg output option.
Attachment #426894 - Attachment is patch: true
Attachment #426894 - Attachment mime type: application/octet-stream → text/plain
Attachment #426894 - Flags: review?(karlt)
Attachment #426894 - Flags: approval1.9.2.2?
Attachment #426894 - Flags: approval1.9.1.9?
Attached patch Patch — — Splinter Review 
Hum... without unrelated changes this time
Assignee: nobody → mh+mozilla
Attachment #426894 - Attachment is obsolete: true
Attachment #426895 - Flags: review?
Attachment #426895 - Flags: approval1.9.2.2?
Attachment #426895 - Flags: approval1.9.1.9?
Attachment #426894 - Flags: review?(karlt)
Attachment #426894 - Flags: approval1.9.2.2?
Attachment #426894 - Flags: approval1.9.1.9?
Attachment #426895 - Flags: review? → review?(karlt)
Comment on attachment 426895 [details] [diff] [review]
Patch

Please wait for review(s) to be completed before requesting branch approval.
Attachment #426895 - Flags: approval1.9.2.2?
Attachment #426895 - Flags: approval1.9.1.9?
Comment on attachment 426895 [details] [diff] [review]
Patch

Looks good, thanks.
Attachment #426895 - Flags: review?(karlt) → review+
Let's get this in on mozilla-central.
Keywords: checkin-needed
Whiteboard: [checkin m-c]
Status: NEW → ASSIGNED
Version: 1.9.2 Branch → unspecified
http://hg.mozilla.org/mozilla-central/rev/b40f96c3d2ec
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Keywords: checkin-needed
Whiteboard: [checkin m-c]
Flags have completely changed, what is the one for approval on branches, now ?
"approval1.9.2.2" for Firefox 3.6.2 and "approval1.9.1.9" for Firefox 3.5.9 on https://bugzilla.mozilla.org/attachment.cgi?id=426895&action=edit, I guess.

See https://wiki.mozilla.org/Releases/Flags on the various multi-state flags.
Comment on attachment 426895 [details] [diff] [review]
Patch

D'oh, I was looking for these flags at the wrong place...
Attachment #426895 - Flags: approval1.9.2.2?
Attachment #426895 - Flags: approval1.9.1.9?
Looks safe enough to approve, but how does adding postscript flags turn off SVG output?
Because it's unfortunately how this thing works. There is not even a flag for SVG, so you can't support, e.g. ps and svg but not pdf...

See http://git.gnome.org/browse/gtk+/tree/modules/printbackends/file/gtkprintbackendfile.c#n594
That's even how the flags are documented:
"If neither GTK_PRINT_CAPABILITY_GENERATE_PDF  nor GTK_PRINT_CAPABILITY_GENERATE_PS  is specified, GTK+ assumes that all formats are supported."

Currently Mozilla only supports PDF and PS so it makes sense to explicitly specify these.
http://hg.mozilla.org/mozilla-central/annotate/ab74c935e321/widget/src/gtk2/nsDeviceContextSpecG.cpp#l478
Attachment #426895 - Flags: approval1.9.2.2?
Attachment #426895 - Flags: approval1.9.2.2+
Attachment #426895 - Flags: approval1.9.1.9?
Attachment #426895 - Flags: approval1.9.1.9+
Comment on attachment 426895 [details] [diff] [review]
Patch

Approved for 1.9.1.9 and 1.9.2.2, a=dveditz for release-drivers
Keywords: checkin-needed
Whiteboard: [needs 1.9.0 landing][needs 1.9.1 landing]
Whiteboard: [needs 1.9.0 landing][needs 1.9.1 landing] → [needs 1.9.1 landing][needs 1.9.2 landing]
Keywords: checkin-needed
Whiteboard: [needs 1.9.1 landing][needs 1.9.2 landing]
As given by Karl on IRC the problem here were the missing flags. If no flags are set, the dialog simply offers all possible output formats.

Verified fixed on 1.9.2 with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2

Also works on trunk with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a4pre) Gecko/20100322 Minefield/3.7a4pre
Status: RESOLVED → VERIFIED
Keywords: verified1.9.2
Summary: Print dialog should not display the svg output option → Print dialog should not display the SVG output option when printing to a file
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.