Closed
Bug 546093
Opened 13 years ago
Closed 13 years ago
Print dialog should not display the SVG output option when printing to a file
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a2
People
(Reporter: glandium, Assigned: glandium)
Details
(Keywords: verified1.9.2)
Attachments
(1 file, 1 obsolete file)
630 bytes,
patch
|
karlt
:
review+
dveditz
:
approval1.9.2.2+
dveditz
:
approval1.9.1.9+
|
Details | Diff | Splinter Review |
Until bug 525998 is actually addressed, all currently released branches should force disabling the svg output option.
Assignee | ||
Updated•13 years ago
|
Attachment #426894 -
Attachment is patch: true
Attachment #426894 -
Attachment mime type: application/octet-stream → text/plain
Attachment #426894 -
Flags: review?(karlt)
Attachment #426894 -
Flags: approval1.9.2.2?
Attachment #426894 -
Flags: approval1.9.1.9?
Assignee | ||
Comment 1•13 years ago
|
||
Hum... without unrelated changes this time
Assignee: nobody → mh+mozilla
Attachment #426894 -
Attachment is obsolete: true
Attachment #426895 -
Flags: review?
Attachment #426895 -
Flags: approval1.9.2.2?
Attachment #426895 -
Flags: approval1.9.1.9?
Attachment #426894 -
Flags: review?(karlt)
Attachment #426894 -
Flags: approval1.9.2.2?
Attachment #426894 -
Flags: approval1.9.1.9?
Assignee | ||
Updated•13 years ago
|
Attachment #426895 -
Flags: review? → review?(karlt)
Comment 2•13 years ago
|
||
Comment on attachment 426895 [details] [diff] [review] Patch Please wait for review(s) to be completed before requesting branch approval.
Attachment #426895 -
Flags: approval1.9.2.2?
Attachment #426895 -
Flags: approval1.9.1.9?
Comment 3•13 years ago
|
||
Comment on attachment 426895 [details] [diff] [review] Patch Looks good, thanks.
Attachment #426895 -
Flags: review?(karlt) → review+
Comment 4•13 years ago
|
||
Let's get this in on mozilla-central.
Keywords: checkin-needed
Whiteboard: [checkin m-c]
Updated•13 years ago
|
Status: NEW → ASSIGNED
Version: 1.9.2 Branch → unspecified
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b40f96c3d2ec
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [checkin m-c]
Assignee | ||
Comment 6•13 years ago
|
||
Flags have completely changed, what is the one for approval on branches, now ?
Comment 7•13 years ago
|
||
"approval1.9.2.2" for Firefox 3.6.2 and "approval1.9.1.9" for Firefox 3.5.9 on https://bugzilla.mozilla.org/attachment.cgi?id=426895&action=edit, I guess. See https://wiki.mozilla.org/Releases/Flags on the various multi-state flags.
Assignee | ||
Comment 8•13 years ago
|
||
Comment on attachment 426895 [details] [diff] [review] Patch D'oh, I was looking for these flags at the wrong place...
Attachment #426895 -
Flags: approval1.9.2.2?
Attachment #426895 -
Flags: approval1.9.1.9?
Comment 9•13 years ago
|
||
Looks safe enough to approve, but how does adding postscript flags turn off SVG output?
Assignee | ||
Comment 10•13 years ago
|
||
Because it's unfortunately how this thing works. There is not even a flag for SVG, so you can't support, e.g. ps and svg but not pdf... See http://git.gnome.org/browse/gtk+/tree/modules/printbackends/file/gtkprintbackendfile.c#n594
Comment 11•13 years ago
|
||
That's even how the flags are documented: "If neither GTK_PRINT_CAPABILITY_GENERATE_PDF nor GTK_PRINT_CAPABILITY_GENERATE_PS is specified, GTK+ assumes that all formats are supported." Currently Mozilla only supports PDF and PS so it makes sense to explicitly specify these. http://hg.mozilla.org/mozilla-central/annotate/ab74c935e321/widget/src/gtk2/nsDeviceContextSpecG.cpp#l478
Updated•13 years ago
|
Attachment #426895 -
Flags: approval1.9.2.2?
Attachment #426895 -
Flags: approval1.9.2.2+
Attachment #426895 -
Flags: approval1.9.1.9?
Attachment #426895 -
Flags: approval1.9.1.9+
Comment 12•13 years ago
|
||
Comment on attachment 426895 [details] [diff] [review] Patch Approved for 1.9.1.9 and 1.9.2.2, a=dveditz for release-drivers
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [needs 1.9.0 landing][needs 1.9.1 landing]
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs 1.9.0 landing][needs 1.9.1 landing] → [needs 1.9.1 landing][needs 1.9.2 landing]
Comment 13•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b0ff8632d5ce http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8c44b703f64a
status1.9.1:
--- → .9-fixed
status1.9.2:
--- → .2-fixed
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [needs 1.9.1 landing][needs 1.9.2 landing]
Comment 14•13 years ago
|
||
As given by Karl on IRC the problem here were the missing flags. If no flags are set, the dialog simply offers all possible output formats. Verified fixed on 1.9.2 with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2 Also works on trunk with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a4pre) Gecko/20100322 Minefield/3.7a4pre
Status: RESOLVED → VERIFIED
Keywords: verified1.9.2
Summary: Print dialog should not display the svg output option → Print dialog should not display the SVG output option when printing to a file
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•