54630 - Disk cache not writing files after 512 files reached

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect, P1)

Description

[Tom Everingham]

Overview Description:  After hitting 512 files in the disk cache the cache is 
cleaned up ... ie. all cached files are deleted and the files are not stored to 
disk anymore.  Using about:cache shows the file count (after cleanup) increasing 
as it should but does not display the names of the files.  All of my cache 
directories remain empty and it appears as though nothing is cached anymore.  
I've re-installed twice.

Steps to Reproduce:
1.)  Surf until you have over 512 records in cache

Actual Results:  Cache quits working

Expected Results:  cache files should be saved to disk

Build Date & Platform Bug Found:  2000092808 winNT

Additional info:  my system's acting a little strange tonight so maybe I'm just 
imagining that I'm seeing this

Comment 1

[Tom Everingham]

nominating nsbeta3

Comment 2

[Tom Everingham]

changing platforms to all - checked mac, linux, windows

Comment 3

[Phil Peterson]

It's too late for B3 for this, marking nsbeta3-. Sounds like a good thing to fix
for RTM though.

Comment 4

[neeti]

When we call DBRecovery(..), only the underlying records in the database are 
deleted, but not the nsCachedNetData entries in memory in the replacement 
policy. So the number of deleted entries remains high, even though the number of 
records have decreased. When the number of undeleted entries reaches 512, 
DeleteAtleastOneEntry is called, with target number of records set to 75% of 
512=384. But, at this stage, since DBRecovery had been called earlier, the 
number of records in the database is less than 384. So the following check is 
true,

if (targetNumEntries >= numRecordEntries)
		return NS_ERROR_FAILURE;

and we return an error from CheckForTooManyEntries. At this stage, we stop using 
the cache, since GetCahedNetData returns an error.

Comment 5

[Gagan]

should be fixed for rtm. 

Comment 6

[neeti]

Attachment: patch containing fix

Comment 7

[neeti]

I have a r=dp on this. Waiting for rpotts super review.

Comment 8

[rpotts (gone)]

(sr=rpotts)

This looks good :-)

Comment 9

[Phil Peterson]

rtm++

Comment 10

[neeti]

Checked in a fix for branch and trunk.

Comment 11

[Tom Everingham]

verified on branch:
winNT 101608
Linux rh9 101609
mac os9 101608

need to test on trunk

Comment 12

[Rodney Velasco]

verified on trunk builds...
Oct. 19 Windows NT
Oct. 19 Linux RH7
Oct. 23 Mac OS9
Marking this verified and removing vtrunk keyword