54633 - nsCategoryManagerFactory is not threadsafe

Status: RESOLVED INVALID

(Core :: XPCOM, defect, P3)

Description

[Jon Smirl]

XPConnect standalone is a multithreaded environment. It should be legal to call 
CreateInstance from any thread. CreateInstance uses nsCategoryManagerFactory 
and triggers the non-thread safe assert when called from the non-primary 
thread. NS_IMPL_ISUPPORTS1(nsCategoryManagerFactory, nsIFactory) Even if the 
decision is to serialize CreateInstance it still needs to be callable from any 
thread.

This component needs to be checked for thread safety and switched to the 
THREADSAFE ISUPPORTS macro after any problems are fixed.

Comment 1

[Asa Dotzler [:asa]]

setting Jon Smirl's bugs to New

Comment 2

[Ray Whitmer]

Transferring to default XPCOM owner.

Comment 3

[Asa Dotzler [:asa]]

reasigning warren bugs to default component owners.

Comment 4

[Doug Turner (:dougt)]

reassign all kandrot xpcom bug.

Comment 5

[Jon Smirl]

Really, no thread-safe CreateInstance until 1.1? Isn't this a basic part of 
XPCOM?

Threadsafe CreateInstance needs a thread safe nsCategoryManagerFactory to run 
right.

Comment 6

[Doug Turner (:dougt)]

feel free to send patches :-)

The first goal is to freeze our interfaces with the current bugs.  I set most if
not all of these bugs to 1.0.  It will probably, hopefully, happen prior to
that.  Threadsafety and startup/shutdown bugs which do not have an API change
required to fix them, I set to 1.1.

I hope you understand.

Comment 7

[Doug Turner (:dougt)]

The nsCategoryManagerFactory is only used by InitXPCOM2.  Initalization of XPCOM
is not threadsafe.  Therefore this bug is invalid.