546354 - InlineHashtable::FindOneBit should live in VMPI

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Virtual Machine, enhancement)

Description

[Steven Johnson]

It's a horrible sequence of CPU/compiler-specific nastiness and belongs in VMPI, not in core code.

Comment 1

[Lars T Hansen]

Also, according to Ed there are compiler intrinsics that can be used rather than inline assembler:

"I do know that GCC and MSVC both have intrinsic functions that do what the inline asm does, in this case, and that those intrinsics *do* get optimized well when the surrounding function is inlined.  For example __builtin_ctz() on GCC, and _BitScanForward() on MSVC."

Comment 2

[Lars T Hansen]

From Werner:

"The _BitScanReverse intrinsic is available on x86 as well as x64 so there is no need for raw ASM on Windows at least."

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.