546651 - "Failed to post thread message" while debugging

Status: RESOLVED INVALID

(Core :: IPC, defect)

Description

[Benjamin Smedberg]

While debugging firefox.exe I break into a function. Soon after I get "WARNING: Failed to post thread message!", probably from the plugin process. I did a little printf logging and GetLastError is ERROR_NOT_ENOUGH_QUOTA, which apparently means that that message limit of 10,000 messages is being overrun.

Ideas? Are we posting thread messages in a really tight loop or something?

Comment 1

[Benjamin Smedberg]

Attachment: Keep looping if PostThreadMessage fails, rev. 1

This is a crappy solution: it just keeps looping if PostThreadMessage fails. I'm not sure whether we should do that only if the message queue is full, or for every type of failure. Also not sure if this is only likely to happen when a debugger is present and the Sleep should be much longer, as much as a second.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 427355 [details] [diff] [review]
Keep looping if PostThreadMessage fails, rev. 1

>+#include "nsXULAppAPI.h"

I think this is unnecessary?

>+    ::Sleep(20);

I think 'SwitchToThread' might be more appropriate here.

Comment 3

[Jim Mathies [:jimm]]

We switched to using events in bug 545338.